From 0734c632d583578a52e83cd88063a95455436b83 Mon Sep 17 00:00:00 2001 From: Antoine Pitrou Date: Tue, 10 Nov 2009 20:49:30 +0000 Subject: Issue #7197: Allow unittest.TextTestRunner objects to be pickled and unpickled. This fixes crashes under Windows when trying to run test_multiprocessing in verbose mode. Additionally, Test_TextTestRunner hadn't been enabled in test_unittest. --- Lib/test/test_unittest.py | 16 +++++++++++++++- Lib/unittest/runner.py | 2 ++ Misc/NEWS | 4 ++++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/Lib/test/test_unittest.py b/Lib/test/test_unittest.py index 726ac85..db51f77 100644 --- a/Lib/test/test_unittest.py +++ b/Lib/test/test_unittest.py @@ -17,6 +17,7 @@ from unittest import TestCase, TestProgram import types from copy import deepcopy from cStringIO import StringIO +import pickle ### Support code ################################################################ @@ -3477,6 +3478,19 @@ class Test_TextTestRunner(TestCase): expected = ['startTestRun', 'stopTestRun'] self.assertEqual(events, expected) + def test_pickle_unpickle(self): + # Issue #7197: a TextTestRunner should be (un)pickleable. This is + # required by test_multiprocessing under Windows (in verbose mode). + import StringIO + # cStringIO objects are not pickleable, but StringIO objects are. + stream = StringIO.StringIO("foo") + runner = unittest.TextTestRunner(stream) + for protocol in range(pickle.HIGHEST_PROTOCOL + 1): + s = pickle.dumps(runner, protocol=protocol) + obj = pickle.loads(s) + # StringIO objects never compare equal, a cheap test instead. + self.assertEqual(obj.stream.getvalue(), stream.getvalue()) + class TestDiscovery(TestCase): @@ -3766,7 +3780,7 @@ def test_main(): test_support.run_unittest(Test_TestCase, Test_TestLoader, Test_TestSuite, Test_TestResult, Test_FunctionTestCase, Test_TestSkipping, Test_Assertions, TestLongMessage, - Test_TestProgram, TestCleanUp, TestDiscovery) + Test_TestProgram, TestCleanUp, TestDiscovery, Test_TextTestRunner) if __name__ == "__main__": test_main() diff --git a/Lib/unittest/runner.py b/Lib/unittest/runner.py index 67839f5..99819df 100644 --- a/Lib/unittest/runner.py +++ b/Lib/unittest/runner.py @@ -12,6 +12,8 @@ class _WritelnDecorator(object): self.stream = stream def __getattr__(self, attr): + if attr == 'stream': + raise AttributeError(attr) return getattr(self.stream,attr) def writeln(self, arg=None): diff --git a/Misc/NEWS b/Misc/NEWS index 57183e1..e3638aa 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -426,6 +426,10 @@ Core and Builtins Library ------- +- Issue #7197: Allow unittest.TextTestRunner objects to be pickled and + unpickled. This fixes crashes under Windows when trying to run + test_multiprocessing in verbose mode. + - Issue #7282: Fix a memory leak when an RLock was used in a thread other than those started through `threading.Thread` (for example, using `thread.start_new_thread()`. -- cgit v0.12