From 31da5b2f69d408ac2448eb04ee2892b8aa3aac79 Mon Sep 17 00:00:00 2001 From: Daniel Stutzbach Date: Tue, 24 Aug 2010 20:49:57 +0000 Subject: Issue 8750: Fixed MutableSet's methods to correctly handle reflexive operations, namely x -= x and x ^= x --- Lib/_abcoll.py | 24 +++++++++++++++--------- Lib/test/test_collections.py | 15 +++++++++++++++ Misc/NEWS | 3 +++ 3 files changed, 33 insertions(+), 9 deletions(-) diff --git a/Lib/_abcoll.py b/Lib/_abcoll.py index d3e23c1..cac06e0 100644 --- a/Lib/_abcoll.py +++ b/Lib/_abcoll.py @@ -321,18 +321,24 @@ class MutableSet(Set): return self def __ixor__(self, it: Iterable): - if not isinstance(it, Set): - it = self._from_iterable(it) - for value in it: - if value in self: - self.discard(value) - else: - self.add(value) + if it is self: + self.clear() + else: + if not isinstance(it, Set): + it = self._from_iterable(it) + for value in it: + if value in self: + self.discard(value) + else: + self.add(value) return self def __isub__(self, it: Iterable): - for value in it: - self.discard(value) + if it is self: + self.clear() + else: + for value in it: + self.discard(value) return self MutableSet.register(set) diff --git a/Lib/test/test_collections.py b/Lib/test/test_collections.py index da80baa..75d660d 100644 --- a/Lib/test/test_collections.py +++ b/Lib/test/test_collections.py @@ -526,6 +526,21 @@ class TestCollectionABCs(ABCTestCase): s = MySet([5,43,2,1]) self.assertEqual(s.pop(), 1) + def test_issue8750(self): + empty = WithSet() + full = WithSet(range(10)) + s = WithSet(full) + s -= s + self.assertEqual(s, empty) + s = WithSet(full) + s ^= s + self.assertEqual(s, empty) + s = WithSet(full) + s &= s + self.assertEqual(s, full) + s |= s + self.assertEqual(s, full) + def test_Mapping(self): for sample in [dict]: self.assertIsInstance(sample(), Mapping) diff --git a/Misc/NEWS b/Misc/NEWS index 5d23464..304977b 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -126,6 +126,9 @@ Extensions Library ------- +- Issue #8750: Fixed MutableSet's methods to correctly handle + reflexive operations, namely x -= x and x ^= x. + - Issue #9129: smtpd.py is vulnerable to DoS attacks deriving from missing error handling when accepting a new connection. -- cgit v0.12