From f6e50b4a811477206d1c252a531c31029ea93866 Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Sun, 13 Apr 2014 23:52:01 -0400 Subject: fix sending tuples to custom generator objects with yield from (closes #21209) Debugged by Victor. --- Lib/test/test_pep380.py | 19 +++++++++++++++++++ Misc/NEWS | 3 +++ Python/ceval.c | 2 +- 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/Lib/test/test_pep380.py b/Lib/test/test_pep380.py index 4a43b7d..69194df 100644 --- a/Lib/test/test_pep380.py +++ b/Lib/test/test_pep380.py @@ -993,6 +993,25 @@ class TestPEP380Operation(unittest.TestCase): del inner_gen gc_collect() + def test_send_tuple_with_custom_generator(self): + # See issue #21209. + class MyGen: + def __iter__(self): + return self + def __next__(self): + return 42 + def send(self, what): + nonlocal v + v = what + return None + def outer(): + v = yield from MyGen() + g = outer() + next(g) + v = None + g.send((1, 2, 3, 4)) + self.assertEqual(v, (1, 2, 3, 4)) + def test_main(): from test import support diff --git a/Misc/NEWS b/Misc/NEWS index 6fc6e2f..6e14968 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -10,6 +10,9 @@ Release date: TBA Core and Builtins ----------------- +- Issue #21209: Fix sending tuples to custom generator objects with the yield + from syntax. + - Issue #21134: Fix segfault when str is called on an uninitialized UnicodeEncodeError, UnicodeDecodeError, or UnicodeTranslateError object. diff --git a/Python/ceval.c b/Python/ceval.c index 5db88be..1cc3c94 100644 --- a/Python/ceval.c +++ b/Python/ceval.c @@ -1902,7 +1902,7 @@ PyEval_EvalFrameEx(PyFrameObject *f, int throwflag) if (v == Py_None) retval = Py_TYPE(reciever)->tp_iternext(reciever); else - retval = _PyObject_CallMethodId(reciever, &PyId_send, "O", v); + retval = _PyObject_CallMethodIdObjArgs(reciever, &PyId_send, v, NULL); } Py_DECREF(v); if (retval == NULL) { -- cgit v0.12