From 01241d6c358ba55332c1ba91c65157548349bdc8 Mon Sep 17 00:00:00 2001 From: Vinay Sajip Date: Fri, 21 Jan 2011 23:35:57 +0000 Subject: Issue #10949: Improved robustness of rotating file handlers. --- Lib/logging/handlers.py | 2 ++ Misc/NEWS | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py index 96cdcc6..96384bd 100644 --- a/Lib/logging/handlers.py +++ b/Lib/logging/handlers.py @@ -120,6 +120,7 @@ class RotatingFileHandler(BaseRotatingHandler): """ if self.stream: self.stream.close() + self.stream = None if self.backupCount > 0: for i in range(self.backupCount - 1, 0, -1): sfn = "%s.%d" % (self.baseFilename, i) @@ -316,6 +317,7 @@ class TimedRotatingFileHandler(BaseRotatingHandler): """ if self.stream: self.stream.close() + self.stream = None # get the time that this sequence started at and make it a TimeTuple t = self.rolloverAt - self.interval if self.utc: diff --git a/Misc/NEWS b/Misc/NEWS index 44d39cf..0ae7d7d 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -16,6 +16,8 @@ Core and Builtins Library ------- +- Issue #10949: Improved robustness of rotating file handlers. + - Issue #10955: Fix a potential crash when trying to mmap() a file past its length. Initial patch by Ross Lagerwall. -- cgit v0.12