From bd341629b0435a524f9f355de178af22cc6d31ea Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Fri, 16 Jan 2015 20:43:55 -0500 Subject: capitialize "HttpOnly" and "Secure" as they appear in the standard and other impls (closes #23250) Patch by Jon Dufresne. --- Lib/http/cookies.py | 4 ++-- Lib/test/test_http_cookies.py | 4 ++-- Misc/NEWS | 3 +++ 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/Lib/http/cookies.py b/Lib/http/cookies.py index a6de6d5..3e1abd7 100644 --- a/Lib/http/cookies.py +++ b/Lib/http/cookies.py @@ -330,8 +330,8 @@ class Morsel(dict): "comment" : "Comment", "domain" : "Domain", "max-age" : "Max-Age", - "secure" : "secure", - "httponly" : "httponly", + "secure" : "Secure", + "httponly" : "HttpOnly", "version" : "Version", } diff --git a/Lib/test/test_http_cookies.py b/Lib/test/test_http_cookies.py index 2b0281e..e984252 100644 --- a/Lib/test/test_http_cookies.py +++ b/Lib/test/test_http_cookies.py @@ -114,7 +114,7 @@ class CookieTests(unittest.TestCase): C['Customer']['secure'] = True C['Customer']['httponly'] = True self.assertEqual(C.output(), - 'Set-Cookie: Customer="WILE_E_COYOTE"; httponly; secure') + 'Set-Cookie: Customer="WILE_E_COYOTE"; HttpOnly; Secure') def test_secure_httponly_false_if_not_present(self): C = cookies.SimpleCookie() @@ -152,7 +152,7 @@ class CookieTests(unittest.TestCase): C = cookies.SimpleCookie() C.load('eggs = scrambled ; secure ; path = bar ; foo=foo ') self.assertEqual(C.output(), - 'Set-Cookie: eggs=scrambled; Path=bar; secure\r\nSet-Cookie: foo=foo') + 'Set-Cookie: eggs=scrambled; Path=bar; Secure\r\nSet-Cookie: foo=foo') def test_quoted_meta(self): # Try cookie with quoted meta-data diff --git a/Misc/NEWS b/Misc/NEWS index 4127269..e4912f6 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -44,6 +44,9 @@ Core and Builtins Library ------- +- Issue #23250: In the http.cookies module, capitalize "HttpOnly" and "Secure" + as they are written in the standard. + - Issue #23063: In the disutils' check command, fix parsing of reST with code or code-block directives. -- cgit v0.12