From 870f09a7f4296712de404dccea1c3a7bf52f66c3 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Thu, 17 Jun 2010 21:43:33 +0000 Subject: Issue #8203: Fix IDLE Credits dialog: view_file() uses its encoding argument. --- Lib/idlelib/textView.py | 6 +----- Misc/NEWS | 2 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/Lib/idlelib/textView.py b/Lib/idlelib/textView.py index 3f3c247..e5c551a 100644 --- a/Lib/idlelib/textView.py +++ b/Lib/idlelib/textView.py @@ -62,11 +62,7 @@ def view_text(parent, title, text): def view_file(parent, title, filename, encoding=None): try: - if encoding: - import codecs - textFile = codecs.open(filename, 'r') - else: - textFile = open(filename, 'r') + textFile = open(filename, 'r', encoding=encoding) except IOError: import tkinter.messagebox as tkMessageBox tkMessageBox.showerror(title='File Load Error', diff --git a/Misc/NEWS b/Misc/NEWS index 41ac42d..121e92d 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -2047,6 +2047,8 @@ Installation Library ------- +- Issue #8203: Fix IDLE Credits dialog: view_file() uses its encoding argument. + - Issue #5311: bdist_msi can now build packages that do not depend on a specific Python version. -- cgit v0.12