From 897bba75632dfce87c355e3cd4700468357715a7 Mon Sep 17 00:00:00 2001
From: Denis Osipov <osipov_d@list.ru>
Date: Wed, 7 Jun 2017 22:15:26 +0500
Subject: bpo-30584: Fix test_os fails on non-English Windows (#1980)

* Fix bpo-30584

* Adding a comment mentionning the bpo and explaining what is the identifier

* Add Denis Osipov to Misc/ACKS
---
 Lib/test/test_os.py | 4 +++-
 Misc/ACKS           | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py
index 746b3f8..4a21ff7 100644
--- a/Lib/test/test_os.py
+++ b/Lib/test/test_os.py
@@ -472,7 +472,9 @@ class StatAttributeTests(unittest.TestCase):
         # force CreateFile to fail with ERROR_ACCESS_DENIED.
         DETACHED_PROCESS = 8
         subprocess.check_call(
-            ['icacls.exe', fname, '/deny', 'Users:(S)'],
+            # bpo-30584: Use security identifier *S-1-5-32-545 instead
+            # of localized "Users" to not depend on the locale.
+            ['icacls.exe', fname, '/deny', '*S-1-5-32-545:(S)'],
             creationflags=DETACHED_PROCESS
         )
         result = os.stat(fname)
diff --git a/Misc/ACKS b/Misc/ACKS
index 8a5bf6e..135491d 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1132,6 +1132,7 @@ William Orr
 Michele Orrù
 Tomáš Orsava
 Oleg Oshmyan
+Denis Osipov
 Denis S. Otkidach
 Peter Otten
 Michael Otteneder
-- 
cgit v0.12