From b8a5769a6d35931f4dc5395686f590b5dcb58cdd Mon Sep 17 00:00:00 2001 From: Ross Lagerwall Date: Sat, 26 Mar 2011 21:19:57 +0200 Subject: Issue #11659: Fix ResourceWarning in test_subprocess introduced by #11459. Patch by Ben Hayden. --- Lib/test/test_subprocess.py | 1 + Misc/ACKS | 1 + Misc/NEWS | 3 +++ 3 files changed, 5 insertions(+) diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py index 410849f..837bdb5 100644 --- a/Lib/test/test_subprocess.py +++ b/Lib/test/test_subprocess.py @@ -874,6 +874,7 @@ class ProcessTestCase(BaseTestCase): stdout=subprocess.PIPE, bufsize=0) f = p.stdout + self.addCleanup(f.close) try: self.assertEqual(f.read(4), b"appl") self.assertIn(f, select.select([f], [], [], 0.0)[0]) diff --git a/Misc/ACKS b/Misc/ACKS index 99554da..17091eb 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -325,6 +325,7 @@ Jason Harper Larry Hastings Shane Hathaway Rycharde Hawkes +Ben Hayden Jochen Hayek Christian Heimes Thomas Heller diff --git a/Misc/NEWS b/Misc/NEWS index 6825931..8e69a84 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -48,6 +48,9 @@ Core and Builtins Library ------- +- Issue #11659: Fix ResourceWarning in test_subprocess introduced by #11459. + Patch by Ben Hayden. + - Issue #5537: Fix time2isoz() and time2netscape() functions of httplib.cookiejar for expiration year greater than 2038 on 32-bit systems. -- cgit v0.12