From 3d86e484de6334fe16cbab512744597bd0de4e80 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Wirtel?= Date: Tue, 30 Jan 2018 07:04:36 +0100 Subject: bpo-32681: Fix an uninitialized variable in the C implementation of os.dup2 (GH-5346) See https://bugs.python.org/issue32441 for where this was introduced. --- Misc/NEWS.d/next/C API/2018-01-26-17-29-29.bpo-32681.N1ruWa.rst | 2 ++ Modules/posixmodule.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/C API/2018-01-26-17-29-29.bpo-32681.N1ruWa.rst diff --git a/Misc/NEWS.d/next/C API/2018-01-26-17-29-29.bpo-32681.N1ruWa.rst b/Misc/NEWS.d/next/C API/2018-01-26-17-29-29.bpo-32681.N1ruWa.rst new file mode 100644 index 0000000..1506ec7 --- /dev/null +++ b/Misc/NEWS.d/next/C API/2018-01-26-17-29-29.bpo-32681.N1ruWa.rst @@ -0,0 +1,2 @@ +Fix uninitialized variable 'res' in the C implementation of os.dup2. Patch +by Stéphane Wirtel diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c index 46f3ada..4a1c9f3 100644 --- a/Modules/posixmodule.c +++ b/Modules/posixmodule.c @@ -8012,7 +8012,7 @@ static int os_dup2_impl(PyObject *module, int fd, int fd2, int inheritable) /*[clinic end generated code: output=bc059d34a73404d1 input=c3cddda8922b038d]*/ { - int res; + int res = 0; #if defined(HAVE_DUP3) && \ !(defined(HAVE_FCNTL_H) && defined(F_DUP2FD_CLOEXEC)) /* dup3() is available on Linux 2.6.27+ and glibc 2.9 */ -- cgit v0.12