From e63117a84ef11083be86db7afb2ac2789491ca09 Mon Sep 17 00:00:00 2001 From: Andy Lester Date: Thu, 5 Mar 2020 22:43:36 -0600 Subject: closes bpo-39859: Do not downcast result of hstrerror (GH-18790) set_herror builds a string by calling hstrerror but downcasts its return value to char *. It should be const char *. Automerge-Triggered-By: @benjaminp --- Modules/socketmodule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c index 37b3123..2818ac7 100644 --- a/Modules/socketmodule.c +++ b/Modules/socketmodule.c @@ -658,7 +658,7 @@ set_herror(int h_error) PyObject *v; #ifdef HAVE_HSTRERROR - v = Py_BuildValue("(is)", h_error, (char *)hstrerror(h_error)); + v = Py_BuildValue("(is)", h_error, hstrerror(h_error)); #else v = Py_BuildValue("(is)", h_error, "host not found"); #endif -- cgit v0.12