From 16fa2a10970a92cba1ee1249ed7bcf7d2c131051 Mon Sep 17 00:00:00 2001 From: Georg Brandl Date: Tue, 21 Feb 2012 00:50:13 +0100 Subject: Forgot the "empty string -> hash == 0" special case for strings. --- Objects/unicodeobject.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index 716ca3f..75e9923 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -11219,6 +11219,14 @@ unicode_hash(PyObject *self) if (PyUnicode_READY(self) == -1) return -1; len = PyUnicode_GET_LENGTH(self); + /* + We make the hash of the empty string be 0, rather than using + (prefix ^ suffix), since this slightly obfuscates the hash secret + */ + if (len == 0) { + _PyUnicode_HASH(self) = 0; + return 0; + } /* The hash function as a macro, gets expanded three times below. */ #define HASH(P) \ -- cgit v0.12