From 841b930a41be90c6c05fb4bab8392f50e01d86b7 Mon Sep 17 00:00:00 2001 From: Berker Peksag Date: Sat, 5 Mar 2016 14:05:45 +0200 Subject: Issue #17940: Remove redundant code from _Section.format_help() Output of func(*args) stored in the next line: item_help = join([func(*args) for func, args in self.items]) _Section.items only used by HelpFormatter._add_item() and it looks like it doesn't have any side effects. Patch by Yogesh Chaudhari. --- Lib/argparse.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/Lib/argparse.py b/Lib/argparse.py index cc53841..209b4e9 100644 --- a/Lib/argparse.py +++ b/Lib/argparse.py @@ -210,8 +210,6 @@ class HelpFormatter(object): if self.parent is not None: self.formatter._indent() join = self.formatter._join_parts - for func, args in self.items: - func(*args) item_help = join([func(*args) for func, args in self.items]) if self.parent is not None: self.formatter._dedent() -- cgit v0.12