From 98985a1980304b3c8fee9b9efdac015c6098bd67 Mon Sep 17 00:00:00 2001 From: Serhiy Storchaka Date: Mon, 19 Aug 2013 23:18:23 +0300 Subject: Issue #2537: Remove breaked check which prevented valid regular expressions. Patch by Meador Inge. See also issue #18647. --- Lib/sre_compile.py | 2 -- Lib/test/test_re.py | 10 ++++++++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Lib/sre_compile.py b/Lib/sre_compile.py index 40d2d52..9f59c77 100644 --- a/Lib/sre_compile.py +++ b/Lib/sre_compile.py @@ -358,8 +358,6 @@ def _optimize_unicode(charset, fixup): def _simple(av): # check if av is a "simple" operator lo, hi = av[2].getwidth() - #if lo == 0 and hi == MAXREPEAT: - # raise error("nothing to repeat") return lo == hi == 1 and av[2][0][0] != SUBPATTERN def _compile_info(code, pattern, flags): diff --git a/Lib/test/test_re.py b/Lib/test/test_re.py index c84d4ed..2104437 100644 --- a/Lib/test/test_re.py +++ b/Lib/test/test_re.py @@ -1051,6 +1051,16 @@ class ReTests(unittest.TestCase): [b'xyz'], msg=pattern) + def test_bug_2537(self): + # issue 2537: empty submatches + for outer_op in ('{0,}', '*', '+', '{1,187}'): + for inner_op in ('{0,}', '*', '?'): + r = re.compile("^((x|y)%s)%s" % (inner_op, outer_op)) + m = r.match("xyyzy") + self.assertEqual(m.group(0), "xyy") + self.assertEqual(m.group(1), "") + self.assertEqual(m.group(2), "y") + def run_re_tests(): from test.re_tests import tests, SUCCEED, FAIL, SYNTAX_ERROR if verbose: -- cgit v0.12