From f76231f89a7231fd486b37f728fbb4aab389e4d7 Mon Sep 17 00:00:00 2001 From: Mat M Date: Mon, 13 Nov 2017 02:50:16 -0500 Subject: bpo-32013: _pickle: Add missing Py_DECREF in error case in fast_save_enter() (#4384) --- Modules/_pickle.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Modules/_pickle.c b/Modules/_pickle.c index b71fb93..4b7f1ed 100644 --- a/Modules/_pickle.c +++ b/Modules/_pickle.c @@ -1777,8 +1777,10 @@ fast_save_enter(PicklerObject *self, PyObject *obj) } } key = PyLong_FromVoidPtr(obj); - if (key == NULL) + if (key == NULL) { + self->fast_nesting = -1; return 0; + } if (PyDict_GetItemWithError(self->fast_memo, key)) { Py_DECREF(key); PyErr_Format(PyExc_ValueError, @@ -1789,6 +1791,8 @@ fast_save_enter(PicklerObject *self, PyObject *obj) return 0; } if (PyErr_Occurred()) { + Py_DECREF(key); + self->fast_nesting = -1; return 0; } if (PyDict_SetItem(self->fast_memo, key, Py_None) < 0) { -- cgit v0.12