From 08ef9d98b2530d0a8e835ef4fb0a2a5f8bf64ced Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Sat, 9 Nov 1996 22:32:05 +0000 Subject: Only call sq_length in Sequence_GetItem for negative index. --- Objects/abstract.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Objects/abstract.c b/Objects/abstract.c index bb197a5..8d07cfa 100644 --- a/Objects/abstract.c +++ b/Objects/abstract.c @@ -666,12 +666,14 @@ PySequence_GetItem(s, i) if(! s) return Py_ReturnNullError(); - if(! ((m=s->ob_type->tp_as_sequence) && m->sq_length && m->sq_item)) + if(! ((m=s->ob_type->tp_as_sequence) && m->sq_item)) return Py_ReturnMethodError("__getitem__"); - if(0 > (l=m->sq_length(s))) return NULL; - - if(i < 0) i += l; + if(i < 0) + { + if(0 > (l=m->sq_length(s))) return NULL; + i += l; + } return m->sq_item(s,i); } -- cgit v0.12