From 29d55a38ce15062bcabf78a52faa828002b5bbd4 Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Fri, 31 Aug 2001 16:11:15 +0000 Subject: Fix a memory leak in str_subtype_new(). (All the other xxx_subtype_new() functions are OK, but I goofed up in this one. :-( ) --- Objects/stringobject.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Objects/stringobject.c b/Objects/stringobject.c index 7675f7e..4c28500 100644 --- a/Objects/stringobject.c +++ b/Objects/stringobject.c @@ -2713,9 +2713,9 @@ str_subtype_new(PyTypeObject *type, PyObject *args, PyObject *kwds) return NULL; assert(PyString_Check(tmp)); new = type->tp_alloc(type, n = PyString_GET_SIZE(tmp)); - if (new == NULL) - return NULL; - memcpy(PyString_AS_STRING(new), PyString_AS_STRING(tmp), n+1); + if (new != NULL) + memcpy(PyString_AS_STRING(new), PyString_AS_STRING(tmp), n+1); + Py_DECREF(tmp); return new; } -- cgit v0.12