From 1607278c2612275d21354619c6ef1e2869178ba7 Mon Sep 17 00:00:00 2001 From: Christian Heimes Date: Mon, 12 Nov 2007 17:02:51 +0000 Subject: Let's do as Guido says and return None instead of -1 --- Objects/fileobject.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Objects/fileobject.c b/Objects/fileobject.c index ecf6762..6d6022e 100644 --- a/Objects/fileobject.c +++ b/Objects/fileobject.c @@ -387,7 +387,7 @@ stdprinter_write(PyStdPrinter_Object *self, PyObject *args) * I can't raise an exception here. It may lead to an * unlimited recursion in the case stderr is invalid. */ - return PyLong_FromLong((long)-1); + Py_RETURN_NONE; } if (!PyArg_ParseTuple(args, "s", &c)) { @@ -434,8 +434,7 @@ stdprinter_isatty(PyStdPrinter_Object *self) { long res; if (self->fd < 0) { - Py_INCREF(Py_False); - return Py_False; + Py_RETURN_FALSE; } Py_BEGIN_ALLOW_THREADS -- cgit v0.12