From b34ac7371cdc9f269f2f77e24dd1c22fa157d4e4 Mon Sep 17 00:00:00 2001 From: Alex Martelli Date: Sat, 25 Oct 2003 23:22:55 +0000 Subject: regressing the performance bugfix -- Guido wants the performance bug left alone, because there can be no guarantee re the semantics of += vs + . --- Misc/NEWS | 3 --- Python/bltinmodule.c | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/Misc/NEWS b/Misc/NEWS index 0fd0196..7b010f1 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -15,9 +15,6 @@ Core and builtins - Patch #820195: object.__contains__() now returns True or False instead of 1 or 0. -- builtin_sum() now uses PyNumber_InPlaceAdd, fixing a previous - performance bug for sum(list_of_lists) and similar cases. - Extension modules ----------------- diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c index 22d728e..e10d16b 100644 --- a/Python/bltinmodule.c +++ b/Python/bltinmodule.c @@ -1840,7 +1840,7 @@ builtin_sum(PyObject *self, PyObject *args) } break; } - temp = PyNumber_InPlaceAdd(result, item); + temp = PyNumber_Add(result, item); Py_DECREF(result); Py_DECREF(item); result = temp; -- cgit v0.12