From be1cb3214d09d4bf0288bc45f3c1f167f67e4514 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 22 Jun 2021 01:58:19 +0200 Subject: bpo-44287: asyncio test_popen() uses longer timeout (GH-26832) Fix asyncio test_popen() of test_windows_utils by using a longer timeout. Use military grade battle-tested test.support.SHORT_TIMEOUT timeout rather than a hardcoded timeout of 10 seconds: it's 30 seconds by default, but it is made longer on slow buildbots. WaitForMultipleObjects() timeout argument is in milliseconds. --- Lib/test/test_asyncio/test_windows_utils.py | 3 ++- Misc/NEWS.d/next/Tests/2021-06-21-17-53-41.bpo-44287.YON57s.rst | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/Tests/2021-06-21-17-53-41.bpo-44287.YON57s.rst diff --git a/Lib/test/test_asyncio/test_windows_utils.py b/Lib/test/test_asyncio/test_windows_utils.py index 45c09bb..eafa5be 100644 --- a/Lib/test/test_asyncio/test_windows_utils.py +++ b/Lib/test/test_asyncio/test_windows_utils.py @@ -107,7 +107,8 @@ class PopenTests(unittest.TestCase): events = [ovin.event, ovout.event, overr.event] # Super-long timeout for slow buildbots. - res = _winapi.WaitForMultipleObjects(events, True, 10000) + res = _winapi.WaitForMultipleObjects(events, True, + int(support.SHORT_TIMEOUT * 1000)) self.assertEqual(res, _winapi.WAIT_OBJECT_0) self.assertFalse(ovout.pending) self.assertFalse(overr.pending) diff --git a/Misc/NEWS.d/next/Tests/2021-06-21-17-53-41.bpo-44287.YON57s.rst b/Misc/NEWS.d/next/Tests/2021-06-21-17-53-41.bpo-44287.YON57s.rst new file mode 100644 index 0000000..66b3afe --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2021-06-21-17-53-41.bpo-44287.YON57s.rst @@ -0,0 +1,4 @@ +Fix asyncio test_popen() of test_windows_utils by using a longer timeout. +Use military grade battle-tested :data:`test.support.SHORT_TIMEOUT` timeout +rather than a hardcoded timeout of 10 seconds: it's 30 seconds by default, but +it is made longer on slow buildbots. Patch by Victor Stinner. -- cgit v0.12