From e6f96cf9c62e38514e8f5465a1c43f85d861adb2 Mon Sep 17 00:00:00 2001 From: Dong-hee Na Date: Wed, 19 Jul 2023 15:12:38 +0900 Subject: gh-106751: Optimize SelectSelector.select() for many iteration case (gh-106879) --- Lib/selectors.py | 18 ++++++++---------- .../2023-07-19-10-45-24.gh-issue-106751.3HJ1of.rst | 2 ++ 2 files changed, 10 insertions(+), 10 deletions(-) create mode 100644 Misc/NEWS.d/next/Library/2023-07-19-10-45-24.gh-issue-106751.3HJ1of.rst diff --git a/Lib/selectors.py b/Lib/selectors.py index d134059..13497a2 100644 --- a/Lib/selectors.py +++ b/Lib/selectors.py @@ -314,17 +314,15 @@ class SelectSelector(_BaseSelectorImpl): r, w, _ = self._select(self._readers, self._writers, [], timeout) except InterruptedError: return ready - r = set(r) - w = set(w) - for fd in r | w: - events = 0 - if fd in r: - events |= EVENT_READ - if fd in w: - events |= EVENT_WRITE - - key = self._fd_to_key.get(fd) + r = frozenset(r) + w = frozenset(w) + rw = r | w + fd_to_key_get = self._fd_to_key.get + for fd in rw: + key = fd_to_key_get(fd) if key: + events = ((fd in r and EVENT_READ) + | (fd in w and EVENT_WRITE)) ready.append((key, events & key.events)) return ready diff --git a/Misc/NEWS.d/next/Library/2023-07-19-10-45-24.gh-issue-106751.3HJ1of.rst b/Misc/NEWS.d/next/Library/2023-07-19-10-45-24.gh-issue-106751.3HJ1of.rst new file mode 100644 index 0000000..2696b56 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2023-07-19-10-45-24.gh-issue-106751.3HJ1of.rst @@ -0,0 +1,2 @@ +Optimize :meth:`SelectSelector.select` for many iteration case. Patch By +Dong-hee Na. -- cgit v0.12