From 38c741c1fcd432fa8740bed263c82339f9cc0b70 Mon Sep 17 00:00:00 2001 From: Vinay Sajip Date: Sun, 6 Oct 2013 18:36:00 +0100 Subject: Issue #19182: Fixed socket leak on exception when connecting. --- Lib/logging/handlers.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py index b0b0a16..b2e7d44 100644 --- a/Lib/logging/handlers.py +++ b/Lib/logging/handlers.py @@ -518,7 +518,11 @@ class SocketHandler(logging.Handler): else: result = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) result.settimeout(timeout) - result.connect(self.address) + try: + result.connect(self.address) + except OSError: + result.close() # Issue 19182 + raise return result def createSocket(self): -- cgit v0.12