From 2256a2876b5214a5a7492bf78bd86cf8beb690bf Mon Sep 17 00:00:00 2001 From: Erlend Egeberg Aasland Date: Sat, 13 Mar 2021 16:33:39 +0100 Subject: bpo-43444: Move sqlite3 MODULE_NAME from setup.py to module.h (GH-24801) --- Modules/_sqlite/cache.h | 3 +-- Modules/_sqlite/module.h | 1 + Modules/_sqlite/prepare_protocol.h | 3 +-- PCbuild/_sqlite3.vcxproj | 1 - setup.py | 5 ----- 5 files changed, 3 insertions(+), 10 deletions(-) diff --git a/Modules/_sqlite/cache.h b/Modules/_sqlite/cache.h index 4a1977f..083356f 100644 --- a/Modules/_sqlite/cache.h +++ b/Modules/_sqlite/cache.h @@ -23,8 +23,7 @@ #ifndef PYSQLITE_CACHE_H #define PYSQLITE_CACHE_H -#define PY_SSIZE_T_CLEAN -#include "Python.h" +#include "module.h" /* The LRU cache is implemented as a combination of a doubly-linked with a * dictionary. The list items are of type 'Node' and the dictionary has the diff --git a/Modules/_sqlite/module.h b/Modules/_sqlite/module.h index 3185ec9..9aede92 100644 --- a/Modules/_sqlite/module.h +++ b/Modules/_sqlite/module.h @@ -27,6 +27,7 @@ #include "Python.h" #define PYSQLITE_VERSION "2.6.0" +#define MODULE_NAME "sqlite3" extern PyObject* pysqlite_Error; extern PyObject* pysqlite_Warning; diff --git a/Modules/_sqlite/prepare_protocol.h b/Modules/_sqlite/prepare_protocol.h index 42d07cb..5939613 100644 --- a/Modules/_sqlite/prepare_protocol.h +++ b/Modules/_sqlite/prepare_protocol.h @@ -23,8 +23,7 @@ #ifndef PYSQLITE_PREPARE_PROTOCOL_H #define PYSQLITE_PREPARE_PROTOCOL_H -#define PY_SSIZE_T_CLEAN -#include "Python.h" +#include "module.h" typedef struct { diff --git a/PCbuild/_sqlite3.vcxproj b/PCbuild/_sqlite3.vcxproj index 7e00626..5eb8559 100644 --- a/PCbuild/_sqlite3.vcxproj +++ b/PCbuild/_sqlite3.vcxproj @@ -94,7 +94,6 @@ $(sqlite3Dir);%(AdditionalIncludeDirectories) - MODULE_NAME="sqlite3";%(PreprocessorDefinitions) diff --git a/setup.py b/setup.py index 5547722..3467f55 100644 --- a/setup.py +++ b/setup.py @@ -1571,12 +1571,7 @@ class PyBuildExt(build_ext): '_sqlite/row.c', '_sqlite/statement.c', '_sqlite/util.c', ] - sqlite_defines = [] - if not MS_WINDOWS: - sqlite_defines.append(('MODULE_NAME', '"sqlite3"')) - else: - sqlite_defines.append(('MODULE_NAME', '\\"sqlite3\\"')) # Enable support for loadable extensions in the sqlite3 module # if --enable-loadable-sqlite-extensions configure option is used. -- cgit v0.12