From 3273cb5eee505944f0bcce6abf8d1a6d5ff14e9c Mon Sep 17 00:00:00 2001 From: Neal Norwitz Date: Sun, 12 Feb 2006 21:07:17 +0000 Subject: Backport r42314 which fixed Windows breakage when checking that socket descriptors fit in fd_set. Introduce Py_SOCKET_FD_CAN_BE_GE_FD_SETSIZE. Proposed by Tim Peters implemented by Martin von Loewis. --- Modules/_ssl.c | 2 ++ Modules/socketmodule.c | 7 +++++++ PC/pyconfig.h | 5 +++++ 3 files changed, 14 insertions(+) diff --git a/Modules/_ssl.c b/Modules/_ssl.c index 23e7538..fdfaabc 100644 --- a/Modules/_ssl.c +++ b/Modules/_ssl.c @@ -377,8 +377,10 @@ check_socket_and_wait_for_timeout(PySocketSockObject *s, int writing) return SOCKET_HAS_BEEN_CLOSED; /* Guard against socket too large for select*/ +#ifndef Py_SOCKET_FD_CAN_BE_GE_FD_SETSIZE if (s->sock_fd >= FD_SETSIZE) return SOCKET_INVALID; +#endif /* Construct the arguments to select */ tv.tv_sec = (int)s->sock_timeout; diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c index e0af01a..0efa947 100644 --- a/Modules/socketmodule.c +++ b/Modules/socketmodule.c @@ -391,7 +391,14 @@ static int taskwindow; static PyTypeObject sock_type; /* Can we call select() with this socket without a buffer overrun? */ +#ifdef Py_SOCKET_FD_CAN_BE_GE_FD_SETSIZE +/* Platform can select file descriptors beyond FD_SETSIZE */ +#define IS_SELECTABLE(s) 1 +#else +/* POSIX says selecting file descriptors beyond FD_SETSIZE + has undefined behaviour. */ #define IS_SELECTABLE(s) ((s)->sock_fd < FD_SETSIZE) +#endif static PyObject* select_error(void) diff --git a/PC/pyconfig.h b/PC/pyconfig.h index 1979b7e..793fbed 100644 --- a/PC/pyconfig.h +++ b/PC/pyconfig.h @@ -562,4 +562,9 @@ Py_NO_ENABLE_SHARED to find out. Also support MS_NO_COREDLL for b/w compat */ /* Define if you have the thread library (-lthread). */ /* #undef HAVE_LIBTHREAD */ + +/* WinSock does not use a bitmask in select, and uses + socket handles greater than FD_SETSIZE */ +#define Py_SOCKET_FD_CAN_BE_GE_FD_SETSIZE + #endif /* !Py_CONFIG_H */ -- cgit v0.12