From 949f3317312c64425efae21bda86b98423aac9cf Mon Sep 17 00:00:00 2001 From: Christian Heimes Date: Mon, 10 Sep 2012 02:45:31 +0200 Subject: Py_TYPE() has already dereferenced self before the NULL check. Moved Py_TYPE() after the check for self == NULL --- Objects/classobject.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Objects/classobject.c b/Objects/classobject.c index b7d35ef..f956852 100644 --- a/Objects/classobject.c +++ b/Objects/classobject.c @@ -218,7 +218,7 @@ method_repr(PyMethodObject *a) { PyObject *self = a->im_self; PyObject *func = a->im_func; - PyObject *klass = (PyObject*)Py_TYPE(self); + PyObject *klass; PyObject *funcname = NULL ,*klassname = NULL, *result = NULL; char *defname = "?"; @@ -226,6 +226,7 @@ method_repr(PyMethodObject *a) PyErr_BadInternalCall(); return NULL; } + klass = (PyObject*)Py_TYPE(self); funcname = PyObject_GetAttrString(func, "__name__"); if (funcname == NULL) { -- cgit v0.12