From b44ffc8b409fd539c5fb2b79385498e9fe168880 Mon Sep 17 00:00:00 2001 From: Marco Paolini Date: Fri, 15 Nov 2019 08:42:51 +0000 Subject: bpo-38677: Fix arraymodule error handling in module initialization. (GH-17039) --- Modules/arraymodule.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/Modules/arraymodule.c b/Modules/arraymodule.c index 5ba2618..1ceba9e 100644 --- a/Modules/arraymodule.c +++ b/Modules/arraymodule.c @@ -3040,9 +3040,15 @@ array_modexec(PyObject *m) Py_TYPE(&PyArrayIter_Type) = &PyType_Type; Py_INCREF((PyObject *)&Arraytype); - PyModule_AddObject(m, "ArrayType", (PyObject *)&Arraytype); + if (PyModule_AddObject(m, "ArrayType", (PyObject *)&Arraytype) < 0) { + Py_DECREF((PyObject *)&Arraytype); + return -1; + } Py_INCREF((PyObject *)&Arraytype); - PyModule_AddObject(m, "array", (PyObject *)&Arraytype); + if (PyModule_AddObject(m, "array", (PyObject *)&Arraytype) < 0) { + Py_DECREF((PyObject *)&Arraytype); + return -1; + } for (descr=descriptors; descr->typecode != '\0'; descr++) { size++; @@ -3053,13 +3059,11 @@ array_modexec(PyObject *m) *p++ = (char)descr->typecode; } typecodes = PyUnicode_DecodeASCII(buffer, p - buffer, NULL); - - PyModule_AddObject(m, "typecodes", typecodes); - - if (PyErr_Occurred()) { - Py_DECREF(m); - m = NULL; + if (PyModule_AddObject(m, "typecodes", typecodes) < 0) { + Py_XDECREF(typecodes); + return -1; } + return 0; } -- cgit v0.12