From fe52eb62191e640e720d184a9a1a04e965b8a062 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Wed, 28 Apr 2021 15:47:10 +0200 Subject: bpo-43961: Fix test_logging.test_namer_rotator_inheritance() (GH-25684) Fix test_logging.test_namer_rotator_inheritance() on Windows: use os.replace() rather than os.rename(). --- Lib/test/test_logging.py | 2 +- Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py index bb31e29..1d061e4 100644 --- a/Lib/test/test_logging.py +++ b/Lib/test/test_logging.py @@ -5219,7 +5219,7 @@ class RotatingFileHandlerTest(BaseFileTest): def rotator(self, source, dest): if os.path.exists(source): - os.rename(source, dest + ".rotated") + os.replace(source, dest + ".rotated") rh = HandlerWithNamerAndRotator( self.fn, encoding="utf-8", backupCount=2, maxBytes=1) diff --git a/Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst b/Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst new file mode 100644 index 0000000..e56572f --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst @@ -0,0 +1,2 @@ +Fix test_logging.test_namer_rotator_inheritance() on Windows: use +:func:`os.replace` rather than :func:`os.rename`. Patch by Victor Stinner. -- cgit v0.12