From c14bae47b805ab518140fc36bf95e86b1df114aa Mon Sep 17 00:00:00 2001 From: Vinay Sajip Date: Mon, 25 Jun 2012 23:17:07 +0100 Subject: Issue #15179: Closed socket on connection failure. Thanks to Kazutaka Morita for the patch. --- Lib/logging/handlers.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py index 5af73e9..19a5f10 100644 --- a/Lib/logging/handlers.py +++ b/Lib/logging/handlers.py @@ -771,7 +771,11 @@ class SysLogHandler(logging.Handler): except socket.error: self.socket.close() self.socket = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) - self.socket.connect(address) + try: + self.socket.connect(address) + except socket.error: + self.socket.close() + raise # curious: when talking to the unix-domain '/dev/log' socket, a # zero-terminator seems to be required. this string is placed -- cgit v0.12