From 9c4585acfa28cd460c80b9b3ab6de5c257eaeec5 Mon Sep 17 00:00:00 2001 From: Sjoerd Mullender Date: Tue, 15 Aug 1995 11:33:39 +0000 Subject: Removed addbase.__del__ because it can't work. If code keeps a reference to self.fp or any of its methods, you don't want to close self.fp just because no explicit reference is kept to self. --- Lib/urllib.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Lib/urllib.py b/Lib/urllib.py index 380a852..f83bafd 100644 --- a/Lib/urllib.py +++ b/Lib/urllib.py @@ -442,8 +442,12 @@ class addbase: def __repr__(self): return '<%s at %s whose fp = %s>' % ( self.__class__.__name__, `id(self)`, `self.fp`) - def __del__(self): - self.close() +# Removed this __del__ because it can't work like this. If a +# reference is kept to self.fp or any of its methods, but no reference +# is kept to self, we don't want to close self.fp (which would happen +# if this __del__ still existed). +# def __del__(self): +# self.close() def close(self): self.read = None self.readline = None -- cgit v0.12