From 6e3b7cf3af3ed7758b2c2193c1d393feb8ab8f72 Mon Sep 17 00:00:00 2001 From: Pablo Galindo Date: Sat, 5 Jun 2021 23:41:11 +0100 Subject: bpo-44304: Ensure the sqlite3 destructor callback is always called with the GIL held (GH-26551) --- Modules/_sqlite/connection.c | 5 +++++ Modules/_sqlite/statement.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a/Modules/_sqlite/connection.c b/Modules/_sqlite/connection.c index c2f3bc0..fbee1b7 100644 --- a/Modules/_sqlite/connection.c +++ b/Modules/_sqlite/connection.c @@ -825,7 +825,12 @@ static void _pysqlite_drop_unused_cursor_references(pysqlite_Connection* self) static void _destructor(void* args) { + // This function may be called without the GIL held, so we need to ensure + // that we destroy 'args' with the GIL + PyGILState_STATE gstate; + gstate = PyGILState_Ensure(); Py_DECREF((PyObject*)args); + PyGILState_Release(gstate); } /*[clinic input] diff --git a/Modules/_sqlite/statement.c b/Modules/_sqlite/statement.c index c9dd882..f12ef67 100644 --- a/Modules/_sqlite/statement.c +++ b/Modules/_sqlite/statement.c @@ -404,7 +404,9 @@ stmt_dealloc(pysqlite_Statement *self) PyObject_ClearWeakRefs((PyObject*)self); } if (self->st) { + Py_BEGIN_ALLOW_THREADS sqlite3_finalize(self->st); + Py_END_ALLOW_THREADS self->st = 0; } tp->tp_clear((PyObject *)self); -- cgit v0.12