From 879d43b705faab0c59f1a6a0042e286f39f3a4ef Mon Sep 17 00:00:00 2001 From: Sam Gross Date: Fri, 31 May 2024 14:18:24 -0400 Subject: gh-119799: Add missing `_Py_IncRefTotal` to `_Py_NewRefWithLock` (#119800) The free-threaded refleak builds were reporting negative refcount deltas in some tests because of a missing `_Py_NewRefWithLock`. --- Include/internal/pycore_object.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Include/internal/pycore_object.h b/Include/internal/pycore_object.h index 7602248..f63e1da 100644 --- a/Include/internal/pycore_object.h +++ b/Include/internal/pycore_object.h @@ -497,6 +497,9 @@ _Py_NewRefWithLock(PyObject *op) if (_Py_TryIncrefFast(op)) { return op; } +#ifdef Py_REF_DEBUG + _Py_IncRefTotal(_PyThreadState_GET()); +#endif _Py_INCREF_STAT_INC(); for (;;) { Py_ssize_t shared = _Py_atomic_load_ssize_relaxed(&op->ob_ref_shared); -- cgit v0.12