From e8e4283cecd99ce7eb07c2786e385d22946e15cd Mon Sep 17 00:00:00 2001 From: Christian Heimes Date: Thu, 16 Apr 2015 17:25:45 +0200 Subject: Remove redundant check for tb != NULL to shut up Coverity . It has been set to Py_None a couple of lines earlier. CID 1291697 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking tb suggests that it may be null, but it has already been dereferenced on all paths leading to the check. --- Python/pylifecycle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c index 5618677..a17adf7 100644 --- a/Python/pylifecycle.c +++ b/Python/pylifecycle.c @@ -1283,7 +1283,7 @@ _Py_PrintFatalError(int fd) goto display_stack; } - has_tb = (tb != NULL && tb != Py_None); + has_tb = (tb != Py_None); PyErr_Display(exception, v, tb); Py_XDECREF(exception); Py_XDECREF(v); -- cgit v0.12