From b46004c94f59af1adc081d2a89d9e3f73998ee59 Mon Sep 17 00:00:00 2001 From: Antoine Pitrou Date: Wed, 25 May 2011 18:17:25 +0200 Subject: Issue #12045: Avoid duplicate execution of command in ctypes.util._get_soname(). Patch by Sijin Joseph. --- Lib/ctypes/util.py | 4 +--- Misc/NEWS | 3 +++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Lib/ctypes/util.py b/Lib/ctypes/util.py index e4c204d..6815f94 100644 --- a/Lib/ctypes/util.py +++ b/Lib/ctypes/util.py @@ -137,9 +137,7 @@ elif os.name == "posix": rv = f.close() if rv == 10: raise OSError('objdump command not found') - with contextlib.closing(os.popen(cmd)) as f: - data = f.read() - res = re.search(r'\sSONAME\s+([^\s]+)', data) + res = re.search(r'\sSONAME\s+([^\s]+)', dump) if not res: return None return res.group(1) diff --git a/Misc/NEWS b/Misc/NEWS index 36a3c9d..cba2d50 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -161,6 +161,9 @@ Core and Builtins Library ------- +- Issue #12045: Avoid duplicate execution of command in ctypes.util._get_soname(). + Patch by Sijin Joseph. + - Issue #10818: Remove the Tk GUI and the serve() function of the pydoc module, pydoc -g has been deprecated in Python 3.2 and it has a new enhanced web server. -- cgit v0.12