From 498598e8c2d64232d26c075de87c513415176bbf Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Tue, 24 Jan 2023 14:58:18 -0800 Subject: Fix some comments in ceval.c and fix lltrace output (#101297) The comment at the top was rather outdated. :-) Also added a note about the dangers of dump_stack(). --- Python/ceval.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/Python/ceval.c b/Python/ceval.c index 95eb99b..2e6fed5 100644 --- a/Python/ceval.c +++ b/Python/ceval.c @@ -1,10 +1,5 @@ /* Execute compiled code */ -/* XXX TO DO: - XXX speed up searching for keywords by using a dictionary - XXX document it! - */ - #define _PY_INTERPRETER #include "Python.h" @@ -133,6 +128,9 @@ lltrace_instruction(_PyInterpreterFrame *frame, PyObject **stack_pointer, _Py_CODEUNIT *next_instr) { + /* This dump_stack() operation is risky, since the repr() of some + objects enters the interpreter recursively. It is also slow. + So you might want to comment it out. */ dump_stack(frame, stack_pointer); int oparg = _Py_OPARG(*next_instr); int opcode = _Py_OPCODE(*next_instr); @@ -155,7 +153,7 @@ lltrace_resume_frame(_PyInterpreterFrame *frame) fobj == NULL || !PyFunction_Check(fobj) ) { - printf("\nResuming frame."); + printf("\nResuming frame.\n"); return; } PyFunctionObject *f = (PyFunctionObject *)fobj; -- cgit v0.12