From 34e6f3567e3519e0e8cdb7bbc4b68b9ab40493c8 Mon Sep 17 00:00:00 2001
From: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Date: Fri, 7 Oct 2022 22:41:35 +0100
Subject: gh-92886: [clinic.py] raise exception on invalid input instead of
 assertion (GH-98051)

Tests should pass with -O (assertions off).

Automerge-Triggered-By: GH:iritkatriel
---
 Lib/test/test_clinic.py | 2 +-
 Tools/clinic/clinic.py  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Lib/test/test_clinic.py b/Lib/test/test_clinic.py
index 4aa9691..8ab40c6 100644
--- a/Lib/test/test_clinic.py
+++ b/Lib/test/test_clinic.py
@@ -153,7 +153,7 @@ class ClinicGroupPermuterTest(TestCase):
     def test_have_left_options_but_required_is_empty(self):
         def fn():
             clinic.permute_optional_groups(['a'], [], [])
-        self.assertRaises(AssertionError, fn)
+        self.assertRaises(ValueError, fn)
 
 
 class ClinicLinearFormatTest(TestCase):
diff --git a/Tools/clinic/clinic.py b/Tools/clinic/clinic.py
index 30a6763..a8687e3 100755
--- a/Tools/clinic/clinic.py
+++ b/Tools/clinic/clinic.py
@@ -495,7 +495,8 @@ def permute_optional_groups(left, required, right):
     result = []
 
     if not required:
-        assert not left
+        if left:
+            raise ValueError("required is empty but left is not")
 
     accumulator = []
     counts = set()
-- 
cgit v0.12