From b9c09878ab8390aa9b78ff468f42ed91bae2b1fe Mon Sep 17 00:00:00 2001 From: Tarek Ziade Date: Mon, 30 May 2011 12:25:38 +0200 Subject: displaying the faulty project name is a good idea --- Lib/packaging/metadata.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/Lib/packaging/metadata.py b/Lib/packaging/metadata.py index 596eec7..53d91f7 100644 --- a/Lib/packaging/metadata.py +++ b/Lib/packaging/metadata.py @@ -396,22 +396,24 @@ class Metadata: value = [] if logger.isEnabledFor(logging.WARNING): + project_name = self['Name'] + if name in _PREDICATE_FIELDS and value is not None: for v in value: # check that the values are valid predicates if not is_valid_predicate(v.split(';')[0]): logger.warning( - '%r is not a valid predicate (field %r)', - v, name) + '%r: %r is not a valid predicate (field %r)', + project_name, v, name) # FIXME this rejects UNKNOWN, is that right? elif name in _VERSIONS_FIELDS and value is not None: if not is_valid_versions(value): - logger.warning('%r is not a valid version (field %r)', - value, name) + logger.warning('%r: %r is not a valid version (field %r)', + project_name, value, name) elif name in _VERSION_FIELDS and value is not None: if not is_valid_version(value): - logger.warning('%r is not a valid version (field %r)', - value, name) + logger.warning('%r: %r is not a valid version (field %r)', + project_name, value, name) if name in _UNICODEFIELDS: if name == 'Description': -- cgit v0.12