From f5f1fe0cb5dedf37098622de318656003dc5230d Mon Sep 17 00:00:00 2001 From: Antoine Pitrou Date: Wed, 15 Feb 2012 02:42:46 +0100 Subject: Issue #13015: Fix a possible reference leak in defaultdict.__repr__. Patch by Suman Saha. --- Misc/NEWS | 3 +++ Modules/_collectionsmodule.c | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Misc/NEWS b/Misc/NEWS index 06ce404..0ef337c 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -113,6 +113,9 @@ Core and Builtins Library ------- +- Issue #13015: Fix a possible reference leak in defaultdict.__repr__. + Patch by Suman Saha. + - Issue #10287: nntplib now queries the server's CAPABILITIES first before sending MODE READER, and only sends it if not already in READER mode. Patch by Hynek Schlawack. diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c index 5545d1e..4343159 100644 --- a/Modules/_collectionsmodule.c +++ b/Modules/_collectionsmodule.c @@ -1401,8 +1401,10 @@ defdict_repr(defdictobject *dd) { int status = Py_ReprEnter(dd->default_factory); if (status != 0) { - if (status < 0) + if (status < 0) { + Py_DECREF(baserepr); return NULL; + } defrepr = PyUnicode_FromString("..."); } else -- cgit v0.12