From 79832844727411e374f638d6045e2d100e6c31fd Mon Sep 17 00:00:00 2001 From: Brett Cannon Date: Mon, 3 May 2010 23:57:15 +0000 Subject: Fix two potential uninitialization errors and an unneeded assignment. Found using Clang's static analyzer. --- Modules/bsddbmodule.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Modules/bsddbmodule.c b/Modules/bsddbmodule.c index 0972882..c55df11 100644 --- a/Modules/bsddbmodule.c +++ b/Modules/bsddbmodule.c @@ -270,11 +270,12 @@ bsddb_subscript(bsddbobject *dp, PyObject *key) { int status; DBT krec, drec; - char *data,buf[4096]; + char *data = NULL; + char buf[4096]; int size; PyObject *result; recno_t recno; - + if (dp->di_type == DB_RECNO) { if (!PyArg_Parse(key, "i", &recno)) { PyErr_SetString(PyExc_TypeError, @@ -503,7 +504,8 @@ bsddb_set_location(bsddbobject *dp, PyObject *key) { int status; DBT krec, drec; - char *data,buf[4096]; + char *data = NULL; + char buf[4096]; int size; PyObject *result; recno_t recno; @@ -635,7 +637,7 @@ bsddb_sync(bsddbobject *dp) PyErr_SetFromErrno(BsddbError); return NULL; } - return PyInt_FromLong(status = 0); + return PyInt_FromLong(0); } static PyMethodDef bsddb_methods[] = { {"close", (PyCFunction)bsddb_close, METH_NOARGS}, -- cgit v0.12