From ceeb4173aee7b835f553a8286feaa48b98c16124 Mon Sep 17 00:00:00 2001 From: Carl Meyer Date: Mon, 11 Sep 2023 17:35:49 -0600 Subject: gh-109195: fix source location for super load before LOAD_SUPER_ATTR (#109289) --- Lib/test/test_compile.py | 7 +++++++ .../2023-09-11-15-51-55.gh-issue-109195.iwxmuo.rst | 4 ++++ Python/compile.c | 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/Core and Builtins/2023-09-11-15-51-55.gh-issue-109195.iwxmuo.rst diff --git a/Lib/test/test_compile.py b/Lib/test/test_compile.py index 28b2c46..a8a519f 100644 --- a/Lib/test/test_compile.py +++ b/Lib/test/test_compile.py @@ -1751,6 +1751,13 @@ class TestSourcePositions(unittest.TestCase): list(code.co_consts[1].co_positions()), ) + def test_load_super_attr(self): + source = "class C:\n def __init__(self):\n super().__init__()" + code = compile(source, "", "exec").co_consts[0].co_consts[1] + self.assertOpcodeSourcePositionIs( + code, "LOAD_GLOBAL", line=3, end_line=3, column=4, end_column=9 + ) + class TestExpressionStackSize(unittest.TestCase): # These tests check that the computed stack size for a code object diff --git a/Misc/NEWS.d/next/Core and Builtins/2023-09-11-15-51-55.gh-issue-109195.iwxmuo.rst b/Misc/NEWS.d/next/Core and Builtins/2023-09-11-15-51-55.gh-issue-109195.iwxmuo.rst new file mode 100644 index 0000000..5427232 --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2023-09-11-15-51-55.gh-issue-109195.iwxmuo.rst @@ -0,0 +1,4 @@ +Fix source location for the ``LOAD_*`` instruction preceding a +``LOAD_SUPER_ATTR`` to load the ``super`` global (or shadowing variable) so +that it encompasses only the name ``super`` and not the following +parentheses. diff --git a/Python/compile.c b/Python/compile.c index ae9edc9..1f08e46 100644 --- a/Python/compile.c +++ b/Python/compile.c @@ -4868,7 +4868,7 @@ load_args_for_super(struct compiler *c, expr_ty e) { // load super() global PyObject *super_name = e->v.Call.func->v.Name.id; - RETURN_IF_ERROR(compiler_nameop(c, loc, super_name, Load)); + RETURN_IF_ERROR(compiler_nameop(c, LOC(e->v.Call.func), super_name, Load)); if (asdl_seq_LEN(e->v.Call.args) == 2) { VISIT(c, expr, asdl_seq_GET(e->v.Call.args, 0)); -- cgit v0.12