From f0900199d53df97bd792ac5a1678f8c477f117bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Lapeyre?= Date: Sat, 4 May 2019 01:30:53 +0200 Subject: Suppress clang warning (GH-12384) --- Modules/posixmodule.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c index 56ec3ee..221f710 100644 --- a/Modules/posixmodule.c +++ b/Modules/posixmodule.c @@ -1259,7 +1259,8 @@ _Py_Sigset_Converter(PyObject *obj, void *addr) long signum; int overflow; - if (sigemptyset(mask)) { + // The extra parens suppress the unreachable-code warning with clang on MacOS + if (sigemptyset(mask) < (0)) { /* Probably only if mask == NULL. */ PyErr_SetFromErrno(PyExc_OSError); return 0; -- cgit v0.12