From 547397c45b4c6334ac6e8ee713de012a05a4fe4a Mon Sep 17 00:00:00 2001 From: Tim Peters Date: Sat, 27 Jan 2001 06:20:08 +0000 Subject: SF bug http://sourceforge.net/bugs/?func=detailbug&bug_id=130242&group_id=5470 SF patch http://sourceforge.net/patch/?func=detailpatch&patch_id=103453&group_id=5470 PyMember_Set of T_CHAR always raises exception. Unfortunately, this is a use of a C API function that Python itself never makes, so there's no .py test I can check in to verify this stays fixed. But the fault in the code is obvious, and Dave Cole's patch just as obviously fixes it. --- Misc/ACKS | 1 + Python/structmember.c | 1 + 2 files changed, 2 insertions(+) diff --git a/Misc/ACKS b/Misc/ACKS index 9568547..554203f 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -72,6 +72,7 @@ Tom Christiansen Vadim Chugunov Mike Clarkson Steve Clift +Dave Cole Jeffery Collins Matt Conway Scott Cotton diff --git a/Python/structmember.c b/Python/structmember.c index bc1ba25..e155a6b 100644 --- a/Python/structmember.c +++ b/Python/structmember.c @@ -231,6 +231,7 @@ PyMember_Set(char *addr, struct memberlist *mlist, char *name, PyObject *v) PyErr_BadArgument(); return -1; } + break; default: PyErr_SetString(PyExc_SystemError, "bad memberlist type"); -- cgit v0.12