From a7d329a9b2d01895cb2e6b695ead74855bfeb02a Mon Sep 17 00:00:00 2001 From: Neal Norwitz Date: Fri, 12 Oct 2007 03:04:18 +0000 Subject: Fix Coverity 180: Don't overallocate. We don't need structs, but pointers. Also fix a memory leak. --- Parser/pgen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Parser/pgen.c b/Parser/pgen.c index dfe7cac..76cb204 100644 --- a/Parser/pgen.c +++ b/Parser/pgen.c @@ -124,7 +124,7 @@ addnfa(nfagrammar *gr, char *name) nf = newnfa(name); gr->gr_nfa = (nfa **)PyObject_REALLOC(gr->gr_nfa, - sizeof(nfa) * (gr->gr_nnfas + 1)); + sizeof(nfa*) * (gr->gr_nnfas + 1)); if (gr->gr_nfa == NULL) Py_FatalError("out of mem"); gr->gr_nfa[gr->gr_nnfas++] = nf; @@ -487,6 +487,7 @@ makedfa(nfagrammar *gr, nfa *nf, dfa *d) convert(d, xx_nstates, xx_state); /* XXX cleanup */ + PyObject_FREE(xx_state); } static void -- cgit v0.12