From c87ae806abdf79dd5d000aaec47596122a93b29b Mon Sep 17 00:00:00 2001 From: Steve Dower Date: Fri, 9 Sep 2016 16:37:53 -0700 Subject: Issue #25144: Ensures TargetDir is set before continuing with custom install. --- Misc/NEWS | 3 +++ Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp | 3 +++ 2 files changed, 6 insertions(+) diff --git a/Misc/NEWS b/Misc/NEWS index e05e8e7..aeb38a1 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -275,6 +275,9 @@ Tools/Demos Windows ------- +- Issue #25144: Ensures TargetDir is set before continuing with custom + install. + - Issue #27469: Adds a shell extension to the launcher so that drag and drop works correctly. diff --git a/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp b/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp index b7b2ecf..6a67ee2 100644 --- a/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp +++ b/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp @@ -327,6 +327,9 @@ class PythonBootstrapperApplication : public CBalBaseBootstrapperApplication { case ID_CUSTOM_INSTALL_BUTTON: SavePageSettings(); + hr = EnsureTargetDir(); + ExitOnFailure(hr, L"Failed to set TargetDir"); + hr = BalGetStringVariable(L"TargetDir", &targetDir); if (SUCCEEDED(hr)) { // TODO: Check whether directory exists and contains another installation -- cgit v0.12