From 797c8eb9ef511f0c25f10a453b35c4d2fe383c30 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 14 Sep 2021 17:38:04 +0200 Subject: bpo-45195: Fix test_readline.test_nonascii() (GH-28329) Fix test_readline.test_nonascii(): sometimes, the newline character is not written at the end, so don't expect it in the output. --- Lib/test/test_readline.py | 4 +++- Misc/NEWS.d/next/Tests/2021-09-14-13-16-18.bpo-45195.EyQR1G.rst | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/Tests/2021-09-14-13-16-18.bpo-45195.EyQR1G.rst diff --git a/Lib/test/test_readline.py b/Lib/test/test_readline.py index e8fb8d2..59dbef9 100644 --- a/Lib/test/test_readline.py +++ b/Lib/test/test_readline.py @@ -255,7 +255,9 @@ print("history", ascii(readline.get_history_item(1))) self.assertIn(b"matches ['t\\xebnt', 't\\xebxt']\r\n", output) expected = br"'[\xefnserted]|t\xebxt[after]'" self.assertIn(b"result " + expected + b"\r\n", output) - self.assertIn(b"history " + expected + b"\r\n", output) + # bpo-45195: Sometimes, the newline character is not written at the + # end, so don't expect it in the output. + self.assertIn(b"history " + expected, output) # We have 2 reasons to skip this test: # - readline: history size was added in 6.0 diff --git a/Misc/NEWS.d/next/Tests/2021-09-14-13-16-18.bpo-45195.EyQR1G.rst b/Misc/NEWS.d/next/Tests/2021-09-14-13-16-18.bpo-45195.EyQR1G.rst new file mode 100644 index 0000000..16a1f44 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2021-09-14-13-16-18.bpo-45195.EyQR1G.rst @@ -0,0 +1,3 @@ +Fix test_readline.test_nonascii(): sometimes, the newline character is not +written at the end, so don't expect it in the output. Patch by Victor +Stinner. -- cgit v0.12