From c8759666d5dd923cc5c04459ad119f7821e23be2 Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Sat, 11 May 2013 13:00:05 -0500 Subject: -Wformat is needed by gcc 4.8 (closes #17547) --- Misc/NEWS | 3 +++ configure | 2 +- configure.ac | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Misc/NEWS b/Misc/NEWS index 2c09420..3e177ca 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -95,6 +95,9 @@ Library Build ----- +- Issue #17547: In configure, explicitly pass -Wformat for the benefit for GCC + 4.8. + - Issue #17682: Add the _io module to Modules/Setup.dist (commented out). - Issue #17086: Search the include and library directories provided by the diff --git a/configure b/configure index 528aa51..dc0dfd0 100755 --- a/configure +++ b/configure @@ -6253,7 +6253,7 @@ then { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether gcc supports ParseTuple __format__" >&5 $as_echo_n "checking whether gcc supports ParseTuple __format__... " >&6; } save_CFLAGS=$CFLAGS - CFLAGS="$CFLAGS -Werror" + CFLAGS="$CFLAGS -Werror -Wformat" cat confdefs.h - <<_ACEOF >conftest.$ac_ext /* end confdefs.h. */ diff --git a/configure.ac b/configure.ac index cb2a958..30f5bf4 100644 --- a/configure.ac +++ b/configure.ac @@ -1326,7 +1326,7 @@ if test "$GCC" = "yes" then AC_MSG_CHECKING(whether gcc supports ParseTuple __format__) save_CFLAGS=$CFLAGS - CFLAGS="$CFLAGS -Werror" + CFLAGS="$CFLAGS -Werror -Wformat" AC_COMPILE_IFELSE([ AC_LANG_PROGRAM([[void f(char*,...)__attribute((format(PyArg_ParseTuple, 1, 2)));]], [[]]) ],[ -- cgit v0.12