::checkConsistency(*p); + } +}; +#endif + +} + +#endif // ValueCheck_h diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/Vector.h b/src/3rdparty/webkit/JavaScriptCore/wtf/Vector.h index e1fc5b4..81ea321 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/Vector.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/Vector.h @@ -24,6 +24,7 @@ #include "FastAllocBase.h" #include "Noncopyable.h" #include "NotFound.h" +#include "ValueCheck.h" #include "VectorTraits.h" #include #include @@ -71,7 +72,7 @@ namespace WTF { } template - class VectorDestructor; + struct VectorDestructor; template struct VectorDestructor @@ -90,7 +91,7 @@ namespace WTF { }; template - class VectorInitializer; + struct VectorInitializer; template struct VectorInitializer @@ -118,7 +119,7 @@ namespace WTF { }; template - class VectorMover; + struct VectorMover; template struct VectorMover @@ -162,7 +163,7 @@ namespace WTF { }; template - class VectorCopier; + struct VectorCopier; template struct VectorCopier @@ -187,7 +188,7 @@ namespace WTF { }; template - class VectorFiller; + struct VectorFiller; template struct VectorFiller @@ -212,7 +213,7 @@ namespace WTF { }; template - class VectorComparer; + struct VectorComparer; template struct VectorComparer @@ -586,6 +587,8 @@ namespace WTF { m_buffer.swap(other.m_buffer); } + void checkConsistency(); + private: void expandCapacity(size_t newMinCapacity); const T* expandCapacity(size_t newMinCapacity, const T*); @@ -987,6 +990,15 @@ namespace WTF { } template + inline void Vector::checkConsistency() + { +#if !ASSERT_DISABLED + for (size_t i = 0; i < size(); ++i) + ValueCheck::checkConsistency(at(i)); +#endif + } + + template void deleteAllValues(const Vector& collection) { typedef typename Vector::const_iterator iterator; @@ -1016,6 +1028,15 @@ namespace WTF { return !(a == b); } +#if !ASSERT_DISABLED + template struct ValueCheck > { + typedef Vector TraitType; + static void checkConsistency(const Vector& v) + { + v.checkConsistency(); + } + }; +#endif } // namespace WTF diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/Vector3.h b/src/3rdparty/webkit/JavaScriptCore/wtf/Vector3.h new file mode 100644 index 0000000..3c40b61 --- /dev/null +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/Vector3.h @@ -0,0 +1,138 @@ +/* + * Copyright (C) 2010 Google Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of + * its contributors may be used to endorse or promote products derived + * from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#ifndef Vector3_h +#define Vector3_h + +#include + +namespace WebCore { + +class Vector3 { +public: + Vector3() + : m_x(0.0) + , m_y(0.0) + , m_z(0.0) + { + } + + Vector3(double x, double y, double z) + : m_x(x) + , m_y(y) + , m_z(z) + { + } + + Vector3(const float p[3]) + : m_x(p[0]) + , m_y(p[1]) + , m_z(p[2]) + { + } + + Vector3(const double p[3]) + : m_x(p[0]) + , m_y(p[1]) + , m_z(p[2]) + { + } + + double abs() const + { + return sqrt(m_x * m_x + m_y * m_y + m_z * m_z); + } + + bool isZero() const + { + return !m_x && !m_y && !m_z; + } + + void normalize() + { + double absValue = abs(); + if (!absValue) + return; + + double k = 1.0 / absValue; + m_x *= k; + m_y *= k; + m_z *= k; + } + + double x() const { return m_x; } + double y() const { return m_y; } + double z() const { return m_z; } + +private: + double m_x; + double m_y; + double m_z; +}; + +inline Vector3 operator+(const Vector3& v1, const Vector3& v2) +{ + return Vector3(v1.x() + v2.x(), v1.y() + v2.y(), v1.z() + v2.z()); +} + +inline Vector3 operator-(const Vector3& v1, const Vector3& v2) +{ + return Vector3(v1.x() - v2.x(), v1.y() - v2.y(), v1.z() - v2.z()); +} + +inline Vector3 operator*(double k, const Vector3& v) +{ + return Vector3(k * v.x(), k * v.y(), k * v.z()); +} + +inline Vector3 operator*(const Vector3& v, double k) +{ + return Vector3(k * v.x(), k * v.y(), k * v.z()); +} + +inline double dot(const Vector3& v1, const Vector3& v2) +{ + return v1.x() * v2.x() + v1.y() * v2.y() + v1.z() * v2.z(); +} + +inline Vector3 cross(const Vector3& v1, const Vector3& v2) +{ + double x3 = v1.y() * v2.z() - v1.z() * v2.y(); + double y3 = v1.z() * v2.x() - v1.x() * v2.z(); + double z3 = v1.x() * v2.y() - v1.y() * v2.x(); + return Vector3(x3, y3, z3); +} + +inline double distance(const Vector3& v1, const Vector3& v2) +{ + return (v1 - v2).abs(); +} + +} // WebCore + +#endif // Vector3_h diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/VectorTraits.h b/src/3rdparty/webkit/JavaScriptCore/wtf/VectorTraits.h index eb4c279..bf77878 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/VectorTraits.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/VectorTraits.h @@ -32,7 +32,7 @@ using std::pair; namespace WTF { template - class VectorTraitsBase; + struct VectorTraitsBase; template struct VectorTraitsBase diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.cpp index d75c17a..6289d04 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.cpp @@ -140,7 +140,6 @@ #else #define NO_ERRNO #endif -#include #include #include #include @@ -148,6 +147,7 @@ #include #include #include +#include #include #include @@ -159,9 +159,9 @@ #pragma warning(disable: 4554) #endif -#if PLATFORM(BIG_ENDIAN) +#if CPU(BIG_ENDIAN) #define IEEE_MC68k -#elif PLATFORM(MIDDLE_ENDIAN) +#elif CPU(MIDDLE_ENDIAN) #define IEEE_ARM #else #define IEEE_8087 @@ -262,7 +262,8 @@ typedef union { double d; uint32_t L[2]; } U; #define Pack_32 #endif -#if PLATFORM(PPC64) || PLATFORM(X86_64) +#if CPU(PPC64) || CPU(X86_64) +// FIXME: should we enable this on all 64-bit CPUs? // 64-bit emulation provided by the compiler is likely to be slower than dtoa own code on 32-bit hardware. #define USE_LONG_LONG #endif @@ -560,7 +561,7 @@ static void mult(BigInt& aRef, const BigInt& bRef) aRef = c; } -struct P5Node { +struct P5Node : Noncopyable { BigInt val; P5Node* next; }; @@ -1869,7 +1870,7 @@ static ALWAYS_INLINE int quorem(BigInt& b, BigInt& S) * calculation. */ -void dtoa(char* result, double dd, int ndigits, int* decpt, int* sign, char** rve) +void dtoa(DtoaBuffer result, double dd, int ndigits, int* decpt, int* sign, char** rve) { /* Arguments ndigits, decpt, sign are similar to those @@ -1908,16 +1909,23 @@ void dtoa(char* result, double dd, int ndigits, int* decpt, int* sign, char** rv { /* Infinity or NaN */ *decpt = 9999; - if (!word1(&u) && !(word0(&u) & 0xfffff)) + if (!word1(&u) && !(word0(&u) & 0xfffff)) { strcpy(result, "Infinity"); - else + if (rve) + *rve = result + 8; + } else { strcpy(result, "NaN"); + if (rve) + *rve = result + 3; + } return; } if (!dval(&u)) { *decpt = 1; result[0] = '0'; result[1] = '\0'; + if (rve) + *rve = result + 1; return; } @@ -2376,4 +2384,83 @@ ret: *rve = s; } +static ALWAYS_INLINE void append(char*& next, const char* src, unsigned size) +{ + for (unsigned i = 0; i < size; ++i) + *next++ = *src++; +} + +void doubleToStringInJavaScriptFormat(double d, DtoaBuffer buffer, unsigned* resultLength) +{ + ASSERT(buffer); + + // avoid ever printing -NaN, in JS conceptually there is only one NaN value + if (isnan(d)) { + append(buffer, "NaN", 3); + if (resultLength) + *resultLength = 3; + return; + } + // -0 -> "0" + if (!d) { + buffer[0] = '0'; + if (resultLength) + *resultLength = 1; + return; + } + + int decimalPoint; + int sign; + + DtoaBuffer result; + char* resultEnd = 0; + WTF::dtoa(result, d, 0, &decimalPoint, &sign, &resultEnd); + int length = resultEnd - result; + + char* next = buffer; + if (sign) + *next++ = '-'; + + if (decimalPoint <= 0 && decimalPoint > -6) { + *next++ = '0'; + *next++ = '.'; + for (int j = decimalPoint; j < 0; j++) + *next++ = '0'; + append(next, result, length); + } else if (decimalPoint <= 21 && decimalPoint > 0) { + if (length <= decimalPoint) { + append(next, result, length); + for (int j = 0; j < decimalPoint - length; j++) + *next++ = '0'; + } else { + append(next, result, decimalPoint); + *next++ = '.'; + append(next, result + decimalPoint, length - decimalPoint); + } + } else if (result[0] < '0' || result[0] > '9') + append(next, result, length); + else { + *next++ = result[0]; + if (length > 1) { + *next++ = '.'; + append(next, result + 1, length - 1); + } + + *next++ = 'e'; + *next++ = (decimalPoint >= 0) ? '+' : '-'; + // decimalPoint can't be more than 3 digits decimal given the + // nature of float representation + int exponential = decimalPoint - 1; + if (exponential < 0) + exponential = -exponential; + if (exponential >= 100) + *next++ = static_cast('0' + exponential / 100); + if (exponential >= 10) + *next++ = static_cast('0' + (exponential % 100) / 10); + *next++ = static_cast('0' + exponential % 10); + } + if (resultLength) + *resultLength = next - buffer; +} + } // namespace WTF diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.h b/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.h index cbec7c7..6127f53 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.h @@ -30,8 +30,18 @@ namespace WTF { extern WTF::Mutex* s_dtoaP5Mutex; double strtod(const char* s00, char** se); - void dtoa(char* result, double d, int ndigits, int* decpt, int* sign, char** rve); + + typedef char DtoaBuffer[80]; + void dtoa(DtoaBuffer result, double d, int ndigits, int* decpt, int* sign, char** rve); + + // dtoa() for ECMA-262 'ToString Applied to the Number Type.' + // The *resultLength will have the length of the resultant string in bufer. + // The resultant string isn't terminated by 0. + void doubleToStringInJavaScriptFormat(double, DtoaBuffer, unsigned* resultLength); } // namespace WTF +using WTF::DtoaBuffer; +using WTF::doubleToStringInJavaScriptFormat; + #endif // WTF_dtoa_h diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/qt/ThreadingQt.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/qt/ThreadingQt.cpp index 1fdd2bb..dc04a68 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/qt/ThreadingQt.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/qt/ThreadingQt.cpp @@ -29,6 +29,8 @@ #include "config.h" #include "Threading.h" +#if !ENABLE(SINGLE_THREADED) + #include "CurrentTime.h" #include "HashMap.h" #include "MainThread.h" @@ -64,6 +66,21 @@ void ThreadPrivate::run() m_returnValue = m_entryPoint(m_data); } +class ThreadMonitor : public QObject { + Q_OBJECT +public: + static ThreadMonitor * instance() + { + static ThreadMonitor *instance = new ThreadMonitor(); + return instance; + } + +public Q_SLOTS: + void threadFinished() + { + sender()->deleteLater(); + } +}; static Mutex* atomicallyInitializedStaticMutex; @@ -155,6 +172,9 @@ ThreadIdentifier createThreadInternal(ThreadFunction entryPoint, void* data, con LOG_ERROR("Failed to create thread at entry point %p with data %p", entryPoint, data); return 0; } + + QObject::connect(thread, SIGNAL(finished()), ThreadMonitor::instance(), SLOT(threadFinished())); + thread->start(); QThread* threadRef = static_cast(thread); @@ -162,7 +182,7 @@ ThreadIdentifier createThreadInternal(ThreadFunction entryPoint, void* data, con return establishIdentifierForThread(threadRef); } -void setThreadNameInternal(const char*) +void initializeCurrentThreadInternal(const char*) { } @@ -181,8 +201,10 @@ int waitForThreadCompletion(ThreadIdentifier threadID, void** result) return !res; } -void detachThread(ThreadIdentifier) +void detachThread(ThreadIdentifier threadID) { + ASSERT(threadID); + clearThreadForIdentifier(threadID); } ThreadIdentifier currentThread() @@ -267,3 +289,7 @@ void ThreadCondition::broadcast() } } // namespace WebCore + +#include "ThreadingQt.moc" + +#endif diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/UTF8.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/UTF8.cpp index 9e713fe..21d5856 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/UTF8.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/UTF8.cpp @@ -23,6 +23,7 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +#include "config.h" #include "UTF8.h" namespace WTF { diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.cpp index a779b36..e20c376 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.cpp @@ -19,6 +19,7 @@ * */ +#include "config.h" #include "UnicodeGLib.h" namespace WTF { diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.h b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.h index c03d3ec..d72e707 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.h @@ -26,7 +26,7 @@ #define UnicodeGLib_h #include "UnicodeMacrosFromICU.h" -#include +#include #include #include @@ -152,6 +152,11 @@ inline bool isArabicChar(UChar32 c) return c >= 0x0600 && c <= 0x06FF; } +inline bool isAlphanumeric(UChar32 c) +{ + return g_unichar_isalnum(c); +} + inline bool isFormatChar(UChar32 c) { return g_unichar_type(c) == G_UNICODE_FORMAT; diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/CollatorICU.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/CollatorICU.cpp index 6376bb3..a1753a4 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/CollatorICU.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/CollatorICU.cpp @@ -36,7 +36,7 @@ #include #include -#if PLATFORM(DARWIN) +#if OS(DARWIN) #include "RetainPtr.h" #include #endif @@ -59,9 +59,9 @@ Collator::Collator(const char* locale) std::auto_ptr Collator::userDefault() { -#if PLATFORM(DARWIN) && PLATFORM(CF) +#if OS(DARWIN) && PLATFORM(CF) // Mac OS X doesn't set UNIX locale to match user-selected one, so ICU default doesn't work. -#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !PLATFORM(IPHONE) +#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !OS(IPHONE_OS) RetainPtr currentLocale(AdoptCF, CFLocaleCopyCurrent()); CFStringRef collationOrder = (CFStringRef)CFLocaleGetValue(currentLocale.get(), kCFLocaleCollatorIdentifier); #else diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/UnicodeIcu.h b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/UnicodeIcu.h index 35c6fbf..a2a5c0a 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/UnicodeIcu.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/UnicodeIcu.h @@ -164,6 +164,11 @@ inline bool isArabicChar(UChar32 c) return ublock_getCode(c) == UBLOCK_ARABIC; } +inline bool isAlphanumeric(UChar32 c) +{ + return u_isalnum(c); +} + inline bool isSeparatorSpace(UChar32 c) { return u_charType(c) == U_SPACE_SEPARATOR; diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h index bdf2028..9b1754a 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h @@ -30,7 +30,6 @@ #include -#if QT_VERSION >= 0x040300 QT_BEGIN_NAMESPACE namespace QUnicodeTables { struct Properties { @@ -55,10 +54,9 @@ namespace QUnicodeTables { Q_CORE_EXPORT const Properties * QT_FASTCALL properties(ushort ucs2); } QT_END_NAMESPACE -#endif // ugly hack to make UChar compatible with JSChar in API/JSStringRef.h -#if defined(Q_OS_WIN) || COMPILER(WINSCW) +#if defined(Q_OS_WIN) || COMPILER(WINSCW) || COMPILER(RVCT) typedef wchar_t UChar; #else typedef uint16_t UChar; @@ -186,8 +184,6 @@ enum CharCategory { }; -#if QT_VERSION >= 0x040300 - // FIXME: handle surrogates correctly in all methods inline UChar32 toLower(UChar32 ch) @@ -406,138 +402,6 @@ inline CharCategory category(UChar32 c) return (CharCategory) U_MASK(QChar::category(c)); } -#else - -inline UChar32 toLower(UChar32 ch) -{ - if (ch > 0xffff) - return ch; - return QChar((unsigned short)ch).toLower().unicode(); -} - -inline int toLower(UChar* result, int resultLength, const UChar* src, int srcLength, bool* error) -{ - *error = false; - if (resultLength < srcLength) { - *error = true; - return srcLength; - } - for (int i = 0; i < srcLength; ++i) - result[i] = QChar(src[i]).toLower().unicode(); - return srcLength; -} - -inline UChar32 toUpper(UChar32 ch) -{ - if (ch > 0xffff) - return ch; - return QChar((unsigned short)ch).toUpper().unicode(); -} - -inline int toUpper(UChar* result, int resultLength, const UChar* src, int srcLength, bool* error) -{ - *error = false; - if (resultLength < srcLength) { - *error = true; - return srcLength; - } - for (int i = 0; i < srcLength; ++i) - result[i] = QChar(src[i]).toUpper().unicode(); - return srcLength; -} - -inline int toTitleCase(UChar32 c) -{ - if (c > 0xffff) - return c; - return QChar((unsigned short)c).toUpper().unicode(); -} - -inline UChar32 foldCase(UChar32 c) -{ - if (c > 0xffff) - return c; - return QChar((unsigned short)c).toLower().unicode(); -} - -inline int foldCase(UChar* result, int resultLength, const UChar* src, int srcLength, bool* error) -{ - return toLower(result, resultLength, src, srcLength, error); -} - -inline bool isPrintableChar(UChar32 c) -{ - return (c & 0xffff0000) == 0 && QChar((unsigned short)c).isPrint(); -} - -inline bool isArabicChar(UChar32 c) -{ - return c >= 0x0600 && c <= 0x06FF; -} - -inline bool isSeparatorSpace(UChar32 c) -{ - return (c & 0xffff0000) == 0 && QChar((unsigned short)c).category() == QChar::Separator_Space; -} - -inline bool isPunct(UChar32 c) -{ - return (c & 0xffff0000) == 0 && QChar((unsigned short)c).isPunct(); -} - -inline bool isLower(UChar32 c) -{ - return (c & 0xffff0000) == 0 && QChar((unsigned short)c).category() == QChar::Letter_Lowercase; -} - -inline UChar32 mirroredChar(UChar32 c) -{ - if (c > 0xffff) - return c; - return QChar(c).mirroredChar().unicode(); -} - -inline uint8_t combiningClass(UChar32 c) -{ - if (c > 0xffff) - return 0; - return QChar((unsigned short)c).combiningClass(); -} - -inline DecompositionType decompositionType(UChar32 c) -{ - if (c > 0xffff) - return DecompositionNone; - return (DecompositionType)QChar(c).decompositionTag(); -} - -inline int umemcasecmp(const UChar* a, const UChar* b, int len) -{ - for (int i = 0; i < len; ++i) { - QChar c1 = QChar(a[i]).toLower(); - QChar c2 = QChar(b[i]).toLower(); - if (c1 != c2) - return c1.unicode() - c2.unicode(); - } - return 0; -} - -inline Direction direction(UChar32 c) -{ - if (c > 0xffff) - return LeftToRight; - return (Direction)QChar(c).direction(); -} - -inline CharCategory category(UChar32 c) -{ - if (c > 0xffff) - return NoCategory; - return (CharCategory) U_MASK(QChar(c).category()); -} - -#endif - } } #endif // WTF_UNICODE_QT4_H diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp index 966f2a1..2df44f8 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp @@ -19,6 +19,7 @@ * Boston, MA 02110-1301, USA. */ +#include "config.h" #include "UnicodeWince.h" #include diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/wince/FastMallocWince.h b/src/3rdparty/webkit/JavaScriptCore/wtf/wince/FastMallocWince.h index 93d9f75..37174f0 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/wince/FastMallocWince.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/wince/FastMallocWince.h @@ -1,5 +1,4 @@ /* - * This file is part of the KDE libraries * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. * Copyright (C) 2007-2009 Torch Mobile, Inc. All rights reserved * diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/wince/MemoryManager.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/wince/MemoryManager.cpp index b65b368..81d4f80 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/wince/MemoryManager.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/wince/MemoryManager.cpp @@ -139,25 +139,25 @@ void* fastZeroedMalloc(size_t n) return p; } -void* tryFastMalloc(size_t n) +TryMallocReturnValue tryFastMalloc(size_t n) { MemoryAllocationCanFail canFail; return fastMalloc(n); } -void* tryFastZeroedMalloc(size_t n) +TryMallocReturnValue tryFastZeroedMalloc(size_t n) { MemoryAllocationCanFail canFail; return fastZeroedMalloc(n); } -void* tryFastCalloc(size_t n_elements, size_t element_size) +TryMallocReturnValue tryFastCalloc(size_t n_elements, size_t element_size) { MemoryAllocationCanFail canFail; return fastCalloc(n_elements, element_size); } -void* tryFastRealloc(void* p, size_t n) +TryMallocReturnValue tryFastRealloc(void* p, size_t n) { MemoryAllocationCanFail canFail; return fastRealloc(p, n); diff --git a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexCompiler.cpp b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexCompiler.cpp index c7b3c81..9cd3d12 100644 --- a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexCompiler.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexCompiler.cpp @@ -708,7 +708,7 @@ const char* compileRegex(const UString& patternString, RegexPattern& pattern) unsigned numSubpatterns = pattern.m_numSubpatterns; constructor.reset(); -#ifndef NDEBUG +#if !ASSERT_DISABLED const char* error = #endif parse(constructor, patternString, numSubpatterns); diff --git a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.cpp b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.cpp index 5ce579a..fcb8d86 100644 --- a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.cpp @@ -44,7 +44,7 @@ namespace JSC { namespace Yarr { class RegexGenerator : private MacroAssembler { friend void jitCompileRegex(JSGlobalData* globalData, RegexCodeBlock& jitObject, const UString& pattern, unsigned& numSubpatterns, const char*& error, bool ignoreCase, bool multiline); -#if PLATFORM(ARM) +#if CPU(ARM) static const RegisterID input = ARMRegisters::r0; static const RegisterID index = ARMRegisters::r1; static const RegisterID length = ARMRegisters::r2; @@ -54,7 +54,7 @@ class RegexGenerator : private MacroAssembler { static const RegisterID regT1 = ARMRegisters::r6; static const RegisterID returnRegister = ARMRegisters::r0; -#elif PLATFORM(X86) +#elif CPU(X86) static const RegisterID input = X86Registers::eax; static const RegisterID index = X86Registers::edx; static const RegisterID length = X86Registers::ecx; @@ -64,7 +64,7 @@ class RegexGenerator : private MacroAssembler { static const RegisterID regT1 = X86Registers::esi; static const RegisterID returnRegister = X86Registers::eax; -#elif PLATFORM(X86_64) +#elif CPU(X86_64) static const RegisterID input = X86Registers::edi; static const RegisterID index = X86Registers::esi; static const RegisterID length = X86Registers::edx; @@ -1288,11 +1288,11 @@ class RegexGenerator : private MacroAssembler { void generateEnter() { -#if PLATFORM(X86_64) +#if CPU(X86_64) push(X86Registers::ebp); move(stackPointerRegister, X86Registers::ebp); push(X86Registers::ebx); -#elif PLATFORM(X86) +#elif CPU(X86) push(X86Registers::ebp); move(stackPointerRegister, X86Registers::ebp); // TODO: do we need spill registers to fill the output pointer if there are no sub captures? @@ -1308,7 +1308,7 @@ class RegexGenerator : private MacroAssembler { #else loadPtr(Address(X86Registers::ebp, 2 * sizeof(void*)), output); #endif -#elif PLATFORM(ARM) +#elif CPU(ARM) push(ARMRegisters::r4); push(ARMRegisters::r5); push(ARMRegisters::r6); @@ -1318,15 +1318,15 @@ class RegexGenerator : private MacroAssembler { void generateReturn() { -#if PLATFORM(X86_64) +#if CPU(X86_64) pop(X86Registers::ebx); pop(X86Registers::ebp); -#elif PLATFORM(X86) +#elif CPU(X86) pop(X86Registers::esi); pop(X86Registers::edi); pop(X86Registers::ebx); pop(X86Registers::ebp); -#elif PLATFORM(ARM) +#elif CPU(ARM) pop(ARMRegisters::r6); pop(ARMRegisters::r5); pop(ARMRegisters::r4); diff --git a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.h b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.h index 1872f21..935b9a3 100644 --- a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.h +++ b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.h @@ -37,7 +37,7 @@ #include struct JSRegExp; // temporary, remove when fallback is removed. -#if PLATFORM(X86) && !COMPILER(MSVC) +#if CPU(X86) && !COMPILER(MSVC) #define YARR_CALL __attribute__ ((regparm (3))) #else #define YARR_CALL diff --git a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexPattern.h b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexPattern.h index a451131..dd7512d 100644 --- a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexPattern.h +++ b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexPattern.h @@ -137,7 +137,7 @@ struct PatternTerm { PatternTerm(unsigned spatternId) : type(TypeBackReference) - , invertOrCapture(invertOrCapture) + , invertOrCapture(false) { subpatternId = spatternId; quantityType = QuantifierFixedCount; diff --git a/src/3rdparty/webkit/VERSION b/src/3rdparty/webkit/VERSION index cc0e04f..35511fb 100644 --- a/src/3rdparty/webkit/VERSION +++ b/src/3rdparty/webkit/VERSION @@ -4,8 +4,8 @@ This is a snapshot of the Qt port of WebKit from The commit imported was from the - qtwebkit/qtwebkit-4.6 branch/tag + qtwebkit-4.7-merged branch/tag and has the sha1 checksum - ffae5e11181a3961193fa21ea405851cad714d4b + 5381ceeb37d97365cfb2f037650dbb4e495bca4e diff --git a/src/3rdparty/webkit/WebCore/ChangeLog b/src/3rdparty/webkit/WebCore/ChangeLog index 61c2227..362834e 100644 --- a/src/3rdparty/webkit/WebCore/ChangeLog +++ b/src/3rdparty/webkit/WebCore/ChangeLog @@ -1,59782 +1,9619 @@ -2010-01-14 Diego Gonzalez - - Reviewed by Kenneth Christiansen. +2010-01-07 Laszlo Gombos - [Qt] Missing fileSystemPath() method in Qt KURL implementation - https://bugs.webkit.org/show_bug.cgi?id=33614 + Reviewed by NOBODY (OOPS!). - No new tests. + [RVCT] ACID3 test crash + https://bugs.webkit.org/show_bug.cgi?id=33280 - * platform/qt/KURLQt.cpp: - (WebCore::KURL::fileSystemPath): + Workaround developed by Yongjun Zhang. -2010-02-01 Andreas Kling + * dom/Element.cpp: + (WebCore::Element::setAttribute): - Reviewed by Kenneth Rohde Christiansen. +2009-10-30 Tor Arne Vestbø - [Qt] In the StyledPainter determine the style from the Render and Scrollbar theme instead of from the paint device - https://bugs.webkit.org/show_bug.cgi?id=34054 + Reviewed by NOBODY (OOPS!). - Getting the style from the painter's paint device is a hack that breaks when - the paint device's style is different than the style that is used when - calculating the metries earlier when there is no painter available. + [Qt] Use the default timeout interval for JS as the HTML tokenizer delay for setHtml() - This change moves us closer to always using the same style. + This ensures that long-running JavaScript (for example due to a modal alert() dialog), + will not trigger a deferred load after only 500ms (the default tokenizer delay) while + still giving a reasonable timeout (10 seconds) to prevent deadlock. - * platform/qt/RenderThemeQt.cpp: - (WebCore::StylePainter::StylePainter): - (WebCore::StylePainter::init): - (WebCore::RenderThemeQt::paintButton): - (WebCore::RenderThemeQt::paintTextField): - (WebCore::RenderThemeQt::paintMenuList): - (WebCore::RenderThemeQt::paintMenuListButton): - (WebCore::RenderThemeQt::paintSliderTrack): - (WebCore::RenderThemeQt::paintMediaMuteButton): - (WebCore::RenderThemeQt::paintMediaPlayButton): - (WebCore::RenderThemeQt::paintMediaSliderTrack): - (WebCore::RenderThemeQt::paintMediaSliderThumb): - * platform/qt/RenderThemeQt.h: - * platform/qt/ScrollbarThemeQt.cpp: - (WebCore::ScrollbarThemeQt::paint): - (WebCore::ScrollbarThemeQt::hitTest): - (WebCore::ScrollbarThemeQt::shouldCenterOnThumb): - (WebCore::ScrollbarThemeQt::scrollbarThickness): - (WebCore::ScrollbarThemeQt::thumbLength): - (WebCore::ScrollbarThemeQt::trackPosition): - (WebCore::ScrollbarThemeQt::trackLength): - (WebCore::ScrollbarThemeQt::paintScrollCorner): - (WebCore::ScrollbarThemeQt::style): - * platform/qt/ScrollbarThemeQt.h: - -2010-01-25 Simon Hausmann + https://bugs.webkit.org/show_bug.cgi?id=29381 - Reviewed by Kenneth Rohde Christiansen. + * html/HTMLTokenizer.cpp: Change debug output to print the actual tokenizer delay - [Qt] Use the fallback style on Maemo 5 +2009-10-30 Tor Arne Vestbø - https://bugs.webkit.org/show_bug.cgi?id=34376 + Reviewed by NOBODY (OOPS!). - * platform/qt/RenderThemeQt.cpp: - (WebCore::RenderThemeQt::RenderThemeQt): - (WebCore::RenderThemeQt::fallbackStyle): - (WebCore::RenderThemeQt::qStyle): - (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists): - * platform/qt/RenderThemeQt.h: + Clear the initial request when loading synchronously to prevent duplicate loads -2010-01-29 Oswald Buddenhagen + MainResourceLoader uses the member m_initialRequest to store a request for future + deferred loads. When doing a synchronous load, in handleDataLoadNow(), we therefore + have to clear this request so that subsequent entries into the loader will not start + yet another load. - Reviewed by Simon Hausmann. + This can for example happen in setDefersLoading() as a result of a PageGroupLoadDeferrer + going out of scope when returning from Chrome::runJavaScriptAlert(), where the alert() + came from a script executed as part of the first/original load. - [Qt] Speed up the WebCore::String -> QString conversion + https://bugs.webkit.org/show_bug.cgi?id=30879 - Use QString(const QChar *, int len) constructor instead of QString::fromUtf16 to - avoid BOM checks and byteswapping. + * loader/MainResourceLoader.cpp: + (WebCore::MainResourceLoader::handleDataLoadNow): clear m_initialRequest - * bridge/qt/qt_class.cpp: - (JSC::Bindings::QtClass::fieldNamed): - * bridge/qt/qt_runtime.cpp: - (JSC::Bindings::convertValueToQVariant): +2010-02-20 Laszlo Gombos -2010-01-14 Andreas Kling + Reviewed by Darin Adler. - Reviewed by Kenneth Rohde Christiansen. + Fix compiler warning "suggest parentheses around" + https://bugs.webkit.org/show_bug.cgi?id=35197 - [Qt] Enable scrolling optimization for pages with embedded widgets + No new tests as there is no new functionality. - https://bugs.webkit.org/show_bug.cgi?id=33373 + * html/DateComponents.cpp: + (WebCore::beforeGregorianStartDate): + * plugins/PluginDatabase.cpp: + (WebCore::PluginDatabase::findPlugin): - Added a basic manual test for scrolling of embedded QWidgets. +2010-02-20 Noam Rosenthal - * manual-tests/qt/qtplugin-scrolling.html: Added. - * platform/ScrollView.cpp: - (WebCore::ScrollView::scrollContents): - (WebCore::ScrollView::setParent): - * platform/ScrollView.h: - * platform/qt/ScrollViewQt.cpp: - (WebCore::ScrollView::platformInit): - (WebCore::ScrollView::platformAddChild): - (WebCore::ScrollView::platformRemoveChild): - * plugins/qt/PluginViewQt.cpp: - (WebCore::PluginView::updatePluginWidget): - (WebCore::PluginView::invalidateRect): + Reviewed by Laszlo Gombos. -2010-01-29 Laszlo Gombos + [Qt] ENABLE_3D_RENDERING should be optional + https://bugs.webkit.org/show_bug.cgi?id=35100 - Reviewed by Simon Hausmann. + No new tests: this is a build fix. - [Qt] Turn off websocket support by default for Qt 4.6.x - https://bugs.webkit.org/show_bug.cgi?id=34284 + * WebCore.pri: ENABLE_3D_RENDERING is now a proper feature test - * WebCore.pro: +2010-02-20 Alexey Proskuryakov -2010-01-26 Holger Hans Peter Freyther + Reviewed by Maciej Stachowiak. - Reviewed by Simon Hausmann. + https://bugs.webkit.org/show_bug.cgi?id=23742 + Applet methods can not return arrays to JS - [Qt] JavaScript prompt is currently broken. - https://bugs.webkit.org/show_bug.cgi?id=30914 + * bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaArray::JavaArray): Don't accidentally zero out + m_rootObject (that's how PassRefPtr works). Without m_rootObject, we crash quickly. - Remove the manual test case in favor of an automated - test case in WebKit/qt/tests/qwebpage. + * bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Do handle returned arrays. + Also, added an ifdef around code that's only needed on Tiger, and removed a comment saying + it can be removed when "new" plugin ships. I doubt that anyone can remember what "new" + could refer to back then. - * manual-tests/qt/java-script-prompt.html: Removed. +2010-02-20 Pavel Feldman -2010-01-25 Janne Koskinen + Reviewed by Timothy Hatcher. - Reviewed by Simon Hausmann. + Web Inspector: re-creating view in ResourcesPanel confuses ScriptsPanel's visibleView logic. - [Qt] Phone backup support for QtWebkit for Symbian devices. - https://bugs.webkit.org/show_bug.cgi?id=34077 + https://bugs.webkit.org/show_bug.cgi?id=35192 - * WebCore.pro: + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): + * inspector/front-end/ScriptsPanel.js: + (WebInspector.ScriptsPanel.prototype.show): + (WebInspector.ScriptsPanel.prototype.viewRecreated): -2010-01-21 Thiago Macieira +2010-02-20 Pavel Feldman - Reviewed by Simon Hausmann. + Reviewed by Timothy Hatcher. - [Qt] Fix incorrect dependency to QtXmlPatterns in generated include/QtWebKit/QtWebKit header + Web Inspector: need to highlight the evaluated expression used for popovers. - The generated file includes QtXmlPatterns/QtXmlPatterns, which is neither used/required by - the public QtWebKit API nor will it be available if Qt is configured with -no-xmlpatterns. + https://bugs.webkit.org/show_bug.cgi?id=35126 - * WebCore.pro: Trick syncqt to believe that xmlpatterns is not a dependency, so that it's not - included in the generated file. It'll still be used and linked to with this trick. + * inspector/front-end/SourceFrame.js: + (WebInspector.SourceFrame.prototype._mouseMove): + (WebInspector.SourceFrame.prototype._hidePopup): + (WebInspector.SourceFrame.prototype._mouseHover): + (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): + (WebInspector.SourceFrame.prototype._showPopup): + * inspector/front-end/inspector.css: -2010-01-17 Srinidhi Shreedhara +2010-02-20 Gustavo Noronha Silva - Reviewed by Simon Hausmann. + Roll out 55047 because it causes layout, and API tests to fail - [Qt] [Symbian] SetWindow call in npapi plugin does not happen when the cooridnates are negative - https://bugs.webkit.org/show_bug.cgi?id=33573 +2010-02-19 Gustavo Noronha Silva - * plugins/symbian/PluginViewSymbian.cpp: - (WebCore::PluginView::setNPWindowIfNeeded): Remove tests for negative - coordinates for early return. + Reviewed by Xan Lopez. -2010-01-14 Norbert Leser + [Soup] loses information related to message flags when converting from/to Resource{Request,Response} + https://bugs.webkit.org/show_bug.cgi?id=35093 - Reviewed by Laszlo Gombos. + Refactor updating of ResourceResponse objects from soup message + objects, to avoid code duplication. - Platform Symbian specific: - Added time-based optimization (-Otime) and increased optimization level to -O3, - conditionally for RVCT compiler (for ARM), for increasing performance - (primarily affecting JavaScript execution). - Default settings are -Ospace and -O2. + No behaviour change. - No new tests needed because no new funtionality is introduced, - only potential regression on existing tests needs to be evaluated. + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::fillResponseFromMessage): + * platform/network/soup/ResourceResponseSoup.cpp: + (WebCore::ResourceResponse::updateFromSoupMessage): - * WebCore.pro: +2010-02-20 Alexey Proskuryakov -2010-01-13 Girish Ramakrishnan + Reviewed by Maciej Stachowiak. - Reviewed by Simon Hausmann. + https://bugs.webkit.org/show_bug.cgi?id=35190 + Don't use system malloc in Java bindings - [Qt/Win] Flash in QGraphicsWebView does not process hover correctly. - - https://bugs.webkit.org/show_bug.cgi?id=33591 - - Mouse hover does not work as expected with the flash in some sites. - - http://www.bbc.co.uk/ Hover over the map - - http://www.barbie.com/ Hover over the menu items (Games, Videos) - The problem appears to be that Flash queries NPNVnetscapeWindow on every - mouse hover. I do not how flash uses this value but returning 0 when flash - is in windowless mode solves the problem (When using QGraphicsWebView we - inject wmode opaque, thereby putting the plugin in windowless mode). + * bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Switched to WTF::Vector. - * plugins/win/PluginViewWin.cpp: - (windowHandleForPageClient): +2010-02-20 Alexey Proskuryakov -2010-01-13 Miikka Heikkinen + Reviewed by Maciej Stachowiak. - Reviewed by Simon Hausmann. + https://bugs.webkit.org/show_bug.cgi?id=9761 + LiveConnect string conversion fails for java.lang.Object - [Qt/Symbian] Added missing vendor information to qtwebkit.sis + Can't test Java in DRT (I wonder why). - This information is necessary to Symbian sign the package. + * bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): + Added the necessary conversion. Also, removed CONVERT_NULL_TO_EMPTY_STRING dead code. - http://bugreports.qt.nokia.com/browse/QTBUG-7290 +2010-02-19 Maciej Stachowiak - * WebCore.pro: + Reviewed by David Levin. -2010-01-12 Jakub Wieczorek + Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases + https://bugs.webkit.org/show_bug.cgi?id=35147 - Reviewed by Adam Barth. + I made ENABLE(SANDBOX) only control the sandbox attribute itself; + I did not ifdef the infrastructure to make sandboxing + switchable. This is because the likely concerns about sandboxing + are not stability of the infrastructure code, but rather the fact + that the security model exposed to authors is still evolving. - [Qt] XSL stylesheets can load documents from a different origin + * Configurations/FeatureDefines.xcconfig: + * GNUmakefile.am: + * WebCore.pri: + * html/HTMLIFrameElement.cpp: + (WebCore::HTMLIFrameElement::parseMappedAttribute): - https://bugs.webkit.org/show_bug.cgi?id=33423 +2010-02-19 Alexey Proskuryakov - * xml/XSLTProcessorQt.cpp: - (WebCore::XSLTUriResolver::XSLTUriResolver): - (WebCore::XSLTUriResolver::resolve): - (WebCore::XSLTProcessor::transformToString): + Reviewed by Maciej Stachowiak. -2010-01-07 Yael Aharon + https://bugs.webkit.org/show_bug.cgi?id=35132 + Mouse cursor sometimes flickers over Flash content (35132) - Reviewed by Kenneth Rohde Christiansen. + * page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Don't set mouse + pointer when above a plug-in or applet to prevent flicker. - [Qt] Allow the application to override online/offline network status - https://bugs.webkit.org/show_bug.cgi?id=32684 +2010-02-18 Peter Kasting - Added API to NetworkStateNotifier for forcing network status. + Reviewed by Adam Barth. - * platform/network/NetworkStateNotifier.h: - * platform/network/qt/NetworkStateNotifierPrivate.h: - * platform/network/qt/NetworkStateNotifierQt.cpp: - (WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate): - (WebCore::NetworkStateNotifierPrivate::onlineStateChanged): - (WebCore::NetworkStateNotifierPrivate::networkAccessPermissionChanged): - (WebCore::NetworkStateNotifier::updateState): - (WebCore::NetworkStateNotifier::NetworkStateNotifier): - (WebCore::NetworkStateNotifier::setNetworkAccessAllowed): + Fix regression in calculating an animated image's start time. + https://bugs.webkit.org/show_bug.cgi?id=35115 -2010-01-07 Simon Hausmann + * platform/graphics/BitmapImage.cpp: + (WebCore::BitmapImage::startAnimation): - Reviewed by Tor Arne Vestbø. +2010-02-19 Alexey Proskuryakov - [Qt] Fix linkage against Qt mobility API bearer management module + Reviewed by Geoffrey Garen. - Use the documented .pro file syntax to link against the correct - library and (more importantly) get the include paths correct. + https://bugs.webkit.org/show_bug.cgi?id=35178 + LiveConnect code uses hand-rolled fprintf logging - * WebCore.pro: + Changed to use LOG, LOG_ERROR and ASSERT. -2010-01-07 Laszlo Gombos + * platform/Logging.cpp: + (WebCore::getChannelFromName): + * platform/Logging.h: + * platform/mac/LoggingMac.mm: + (WebCore::InitializeLoggingChannelsIfNecessary): + * platform/win/LoggingWin.cpp: + (WebCore::InitializeLoggingChannelsIfNecessary): + TextConversion channel was (almost) unused, renamed to LiveConnect. + + * platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::registerEncodingNames): + The only use of this channel was in platform specific code, commandeered it for cross-platform + needs. + + * bridge/jni/JNIBridge.cpp: + * bridge/jni/JNIUtility.cpp: + (JSC::Bindings::getJavaVM): + (JSC::Bindings::getJNIEnv): + (JSC::Bindings::getJNIField): + * bridge/jni/JNIUtility.h: + (JSC::Bindings::callJNIMethodV): + (JSC::Bindings::callJNIStaticMethod): + * bridge/jni/jni_jsobject.mm: + (completedJavaScriptAccess): + (dispatchToJavaScriptThread): + (performJavaScriptAccess): + (JavaJSObject::invoke): + (JavaJSObject::call): + (JavaJSObject::eval): + (JavaJSObject::getMember): + (JavaJSObject::setMember): + (JavaJSObject::removeMember): + (JavaJSObject::getSlot): + (JavaJSObject::setSlot): + (JavaJSObject::toString): + (JavaJSObject::createNative): + * bridge/jni/jsc/JNIBridgeJSC.cpp: + (JavaField::valueFromInstance): + (JavaField::setValueToInstance): + * bridge/jni/jsc/JavaClassJSC.cpp: + (JavaClass::JavaClass): + * bridge/jni/jsc/JavaInstanceJSC.cpp: + (JavaInstance::invokeMethod): + (JObjectWrapper::JObjectWrapper): + (JObjectWrapper::~JObjectWrapper): - Reviewed by NOBODY (OOPS!). +2010-02-19 Dirk Schulze - [RVCT] ACID3 test crash - https://bugs.webkit.org/show_bug.cgi?id=33280 + Reviewed by Nikolas Zimmermann. - Workaround developed by Yongjun Zhang. + RenderSVGResourceMasker causes an Assert on Wind builds during DRT + https://bugs.webkit.org/show_bug.cgi?id=35182 - * dom/Element.cpp: - (WebCore::Element::setAttribute): + We remove the Assert for now and return earlier, if the HashMap of the Masker + does not contain the RenderObject. The RenderObject is an identifiert to get + a already calculated mask. + A race condition during parsing can cause the invalidation call, before the mask + got calculated (only during DRT on Win build bots). + The real bug will be fixed with: https://bugs.webkit.org/show_bug.cgi?id=35181 -2010-01-06 Simon Hausmann + * rendering/RenderSVGResourceMasker.cpp: + (WebCore::RenderSVGResourceMasker::invalidateClient): - Unreviewed trivial Qt build fix. +2010-02-18 Peter Kasting - Prefix the phonon includes with phonon/ to avoid conflicts with the S60 - audio routing API ( http://wiki.forum.nokia.com/index.php/Audio_Routing_API ). + Reviewed by Darin Fisher. - * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: + Make Pasteboard::writeImage() safe against NULL cachedImages, and clean + up some code. + https://bugs.webkit.org/show_bug.cgi?id=35136 -2009-12-31 Laszlo Gombos + * loader/ImageLoader.cpp: + (WebCore::ImageLoader::updateRenderer): Shorten some code. + * page/DragController.cpp: + (WebCore::getImage): Shorten some code. + * platform/chromium/PasteboardChromium.cpp: + (WebCore::Pasteboard::writeImage): NULL-check cachedImage(). + * platform/gtk/PasteboardGtk.cpp: + (WebCore::Pasteboard::writeImage): NULL-check cachedImage(). + * platform/mac/PasteboardMac.mm: + (WebCore::Pasteboard::writeImage): NULL-check cachedImage(). + * platform/qt/PasteboardQt.cpp: + (WebCore::Pasteboard::writeImage): NULL-check cachedImage(). + * platform/win/PasteboardWin.cpp: + (WebCore::Pasteboard::writeImage): NULL-check cachedImage(). - Reviewed by Kenneth Rohde Christiansen. +2010-02-19 Kenneth Rohde Christiansen - Do not include Frame.h under WebCore/html/canvas - https://bugs.webkit.org/show_bug.cgi?id=33082 + Rubberstamped by Noam Rosenthal, who wrote the original code. - No new tests, as there is no new functionality. + Make mouse wheel scrolling work when using the GraphicsLayer. - * html/canvas/CanvasRenderingContext2D.cpp: + * platform/graphics/qt/GraphicsLayerQt.cpp: + (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): -2009-12-30 Janne Koskinen +2010-02-19 Nate Chapin - Reviewed by Simon Hausmann. + Reviewed by Dimitri Glazkov. - [Qt] Add support for Symbian def files + [V8] Fix Worker crash regression in r54972 - * WebCore.pro: + https://bugs.webkit.org/show_bug.cgi?id=35166 -2009-12-30 Simon Hausmann + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::V8DOMWrapper::instantiateV8Object): Properly unwrap global objects when inside a WorkerContext. - Unreviewed Qt/Symbian build fix. +2010-02-19 Steve Block - Don't build network state notifier support when building inside of Qt. - Otherwise the Qt build depends on an external module that itself depends - on Qt again. + Not reviewed. Reverts r55020 which causes crashes in Chromium LayoutTests - * WebCore.pro: + * bindings/generic/RuntimeEnabledFeatures.cpp: + * storage/Database.cpp: -2009-12-30 Laszlo Gombos +2010-02-19 Steve Block - Reviewed by Simon Hausmann. + Reviewed by David Levin. - Turn off DataGrid support by default. + Sets default values of V8 runtime enabler flags to match behavior with JSC + https://bugs.webkit.org/show_bug.cgi?id=35095 - No new tests, as there is no new functionality. + No new tests, modifies a Chromium feature only. - * WebCore.pro: + * bindings/generic/RuntimeEnabledFeatures.cpp: Modified. Sets appcache and geolocation flag defaults to 'on' + * storage/Database.cpp: Modified. Sets database flag default to 'on'. -2009-12-17 Yael Aharon +2010-02-19 Alexander Pavlov - Reviewed by Kenneth Rohde Christiansen. + Reviewed by Pavel Feldman. - [Qt] support navigator.onLine and ononline/onoffline events. - https://bugs.webkit.org/show_bug.cgi?id=32555 + WebInspector: Elements panel: Correctly show empty elements' ending tags + for XML and HTML documents. + https://bugs.webkit.org/show_bug.cgi?id=26315 - Hooked up Bearer Management to NetworkStateNotifier. This solution is available - only if QtMobility's Bearer Management is installed. + Test: inspector/elements-panel-xhtml-structure.xhtml - * WebCore.pro: - * platform/network/NetworkStateNotifier.h: - * platform/network/qt/NetworkStateNotifierPrivate.h: Added. - * platform/network/qt/NetworkStateNotifierQt.cpp: Added. - (WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate): - (WebCore::NetworkStateNotifierPrivate::onlineStateChanged): - (WebCore::NetworkStateNotifierPrivate::~NetworkStateNotifierPrivate): - (WebCore::NetworkStateNotifier::updateState): - (WebCore::NetworkStateNotifier::NetworkStateNotifier): + * inspector/InspectorController.cpp: + (WebCore::InspectorController::populateScriptObjects): + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode): + (WebInspector.ElementsTreeOutline.prototype.get isXMLMimeType): + (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired): + (WebInspector.ElementsTreeElement.prototype.onexpand): + (WebInspector.ElementsTreeElement.prototype.oncollapse): + (WebInspector.ElementsTreeElement.prototype.updateTitle.callback): + (WebInspector.ElementsTreeElement.prototype.updateTitle): + (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo): -2009-12-17 Simon Hausmann +2010-02-19 Pavel Feldman - Reviewed by Tor Arne Vestbø. + Not reviewed. Chromium build fix: reverting r54997 and r54998. - [Qt] Symbian build fix: Don't include QtXml/qxmlstream.h but omit the prefix, to - make sure we pick up the header file from QtCore. That is where the implementation - is compiled. + * bindings/v8/custom/V8LocationCustom.cpp: + (WebCore::V8Location::protocolAccessorSetter): + * platform/KURLGoogle.cpp: + (WebCore::KURL::setProtocol): + (WebCore::KURL::isHierarchical): - * dom/XMLTokenizer.h: +2010-02-17 Philippe Normand -2009-12-14 Holger Hans Peter Freyther + Reviewed by Eric Seidel. - Reviewed by Kenneth Rohde Christiansen. + [GTK] RTP/RTSP streams playback support + https://bugs.webkit.org/show_bug.cgi?id=33662 - [Qt] Add manual test for JavaScript prompt corner case - https://bugs.webkit.org/show_bug.cgi?id=30914 + Added live pipelines support in updateStates(). - The patch is based on the work done by Gupta Manish. + * manual-tests/video-rtsp.html: Added. + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: + (WebCore::MediaPlayerPrivate::seek): + (WebCore::MediaPlayerPrivate::updateStates): - Verify behavior of the JavaScript prompt function. Currently - Qt is not behaving like other WebKit ports and Firefox in - regards to accepting the prompt but not entering a text. +2010-02-18 Yaar Schnitman - * manual-tests/qt/java-script-prompt.html: Added. + Reviewed by Darin Adler. -2009-12-21 Andreas Kling + Normalize custom ctors for Image, Option, Audio + https://bugs.webkit.org/show_bug.cgi?id=34782 - Reviewed by Darin Adler. + Test: fast/js/custom-constructors.html - Fix assertion failure when dragging an SVG image. - https://bugs.webkit.org/show_bug.cgi?id=32511 + * bindings/js/JSAudioConstructor.cpp: + (WebCore::JSAudioConstructor::JSAudioConstructor): + (WebCore::constructAudio): + * bindings/js/JSImageConstructor.cpp: + (WebCore::constructImage): + * bindings/js/JSOptionConstructor.cpp: + (WebCore::constructHTMLOptionElement): + * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: + (WebCore::v8HTMLAudioElementConstructorCallback): + * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: + (WebCore::v8HTMLImageElementConstructorCallback): + * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: + (WebCore::v8HTMLOptionElementConstructorCallback): + * html/HTMLAudioElement.cpp: + (WebCore::HTMLAudioElement::HTMLAudioElement): + (WebCore::HTMLAudioElement::createForJSConstructor): + * html/HTMLAudioElement.h: + * html/HTMLImageElement.cpp: + (WebCore::HTMLImageElement::createForJSConstructor): + (WebCore::HTMLImageElement::mapToEntry): + (WebCore::HTMLImageElement::createRenderer): + (WebCore::HTMLImageElement::attach): + (WebCore::HTMLImageElement::width): + (WebCore::HTMLImageElement::height): + (WebCore::HTMLImageElement::naturalHeight): + * html/HTMLImageElement.h: + * html/HTMLOptionElement.cpp: + (WebCore::HTMLOptionElement::HTMLOptionElement): + (WebCore::HTMLOptionElement::createForJSConstructor): + (WebCore::HTMLOptionElement::ownerSelectElement): + (WebCore::HTMLOptionElement::nonRendererRenderStyle): + (WebCore::HTMLOptionElement::disabled): + (WebCore::HTMLOptionElement::insertedIntoTree): + * html/HTMLOptionElement.h: - Test: fast/images/drag-svg-as-image.html +2010-02-12 Brett Wilson - * svg/graphics/SVGImage.cpp: - (WebCore::SVGImage::filenameExtension): Return "svg" - * svg/graphics/SVGImage.h: + Reviewed by Adam Barth. -2009-11-23 Simon Hausmann + Update the Google-URL version of KURL and the V8 bindings to the new + behavior of KURL.IsStandard. - Reviewed by Kenneth Rohde Christiansen. + https://bugs.webkit.org/show_bug.cgi?id=34859 - [Qt] Wrong runtime instance objects of wrapped QObjects may be used if - the wrapped object died before the gc removed the instance. + This is covered by fast/dom/Window/invalid-protocol.html - https://bugs.webkit.org/show_bug.cgi?id=31681 + * bindings/v8/custom/V8LocationCustom.cpp: + (WebCore::V8Location::protocolAccessorSetter): + * platform/KURLGoogle.cpp: + (WebCore::KURL::setProtocol): + (WebCore::KURL::isHierarchical): - Before using a cached instance, verify that its wrapped QObject is - still alive. +2010-02-18 Simon Fraser - * bridge/qt/qt_instance.cpp: - (JSC::Bindings::QtInstance::getQtInstance): - * bridge/qt/qt_instance.h: - (JSC::Bindings::QtInstance::hashKey): + No Review. -2009-11-25 Jocelyn Turcotte + Remove a couple of extraneous spaces that got added to the project file + by hand-ending. - Reviewed by Simon Hausmann. + * WebCore.xcodeproj/project.pbxproj: - [Qt] Fix crash of QtWebKit on any page with Flash when compiled with MinGW. +2010-02-18 Simon Fraser - Fix inline assembly, don't dereference the function pointer twice. + Reviewed by Dan Bernstein. - * plugins/win/PluginViewWin.cpp: - (WebCore::PluginView::hookedBeginPaint): - (WebCore::PluginView::hookedEndPaint): + Page contents missing from snapshot on Newsweek.com article + + Add logic to determine when painting via the software rendering path will give an equivalent + result to the accelerated compositing presentation. This tests for the presence of 3D transforms + via the existing RenderLayerCompositor::has3DContent() method. + + * WebCore.base.exp: Export FrameView's isSoftwareRenderable(), paintBehavior() and setPaintBehavior(). + * page/FrameView.h: + * page/FrameView.cpp: + (WebCore::FrameView::isSoftwareRenderable): New method. + (WebCore::FrameView::paintBehavior): Make this non-inline so that we can reliably export it. -2009-11-22 Jakub Wieczorek +2010-02-18 Dan Bernstein - Reviewed by Adam Barth. + Reviewed by John Sullivan. - [Qt] Remove the Referer header when redirecting to a non-secure site - https://bugs.webkit.org/show_bug.cgi?id=31785 + Multiple style recalcs due to getComputedStyle() on “display: none;” element + when there are pending style sheets - This makes Qt pass two tests introduced in r50226. + Test: fast/css/getComputedStyle/pending-stylesheet.html - * platform/network/qt/QNetworkReplyHandler.cpp: - (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): + When querying a property of a computed style declaration for a non-rendered element, + CSSStyleSelector::styleForElement() was called, and if there were pending style sheet, it + would behave as if the lack of renderer is due to FOUC suppression, and set a flag on + the document causing it to recalculate style. On the next computed style property access, + style would be recalculated for the document, but then the flag would get set again if the + element did not have a renderer. -2009-11-19 Olivier Goffart + * dom/Document.cpp: + (WebCore::Document::styleForElementIgnoringPendingStylesheets): Added. Temporarily sets + m_ignorePendingStylesheets around the call to CSSStyleSelector::styleForElement(). + * dom/Document.h: + * dom/Element.cpp: + (WebCore::Element::computedStyle): Use Document::styleForElementIgnoringPendingStylesheets(). - Reviewed by Simon Hausmann. +2010-02-18 Dirk Schulze - [Qt] Normalize signal and slot signatures. + Reviewed by Nikolas Zimmermann. - * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: - (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): + Move SVGResources to Renderers, starting with Masker + https://bugs.webkit.org/show_bug.cgi?id=35020 -2009-11-18 Benjamin Poulain + We have rendering specific code in WebCore/svg/graphics. The goal is to move + this code into suitable Renderers. This helps us to clean up the code and makes + maintenance easier. It also makes it possible to remove rendering specific code + from SVG*Elements into this renderers. So the Renderer contains everything that + is needed to use the resource. + RenderSVGResource will be the base class for all new resource render classes like + RenderSVGResourceMasker, RenderSVGResourceClipper and the other resources. - Reviewed by Simon Hausmann. + This patch starts moving SVGResourceMasker to RenderSVGResourceMasker. + Another benefit is the much more useful result in DRT on using masker. - [Qt] WebKit crashes when loading certain SVG images + * Android.mk: + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * rendering/RenderObject.cpp: + (WebCore::RenderObject::toRenderSVGResource): Conversion to RenderSVGResource base class. + * rendering/RenderObject.h: + (WebCore::RenderObject::isSVGResource): Check if renderer is a resource. + * rendering/RenderPath.cpp: + * rendering/RenderSVGImage.cpp: + (WebCore::RenderSVGImage::destroy): Renderer gets destroyed, unregister it from it's resources. + * rendering/RenderSVGImage.h: Some code clean up according to the webkit style. + (WebCore::RenderSVGImage::toSVGRenderBase): + (WebCore::RenderSVGImage::renderName): + (WebCore::RenderSVGImage::isSVGImage): + (WebCore::RenderSVGImage::localToParentTransform): + (WebCore::RenderSVGImage::strokeBoundingBox): + (WebCore::RenderSVGImage::requiresLayer): + (WebCore::RenderSVGImage::localTransform): + * rendering/RenderSVGInlineText.h: + (WebCore::RenderSVGInlineText::objectBoundingBox): Needed for SVGRenderTreeAsText + * rendering/RenderSVGModelObject.cpp: + (WebCore::RenderSVGModelObject::destroy): Renderer gets destroyed, unregister it from it's resources. + * rendering/RenderSVGModelObject.h: + * rendering/RenderSVGResource.h: Added. + (WebCore::): Base class for all Resource renderers like masker, clipper and others. + (WebCore::RenderSVGResource::RenderSVGResource): + (WebCore::RenderSVGResource::cast): + (WebCore::RenderSVGResource::toRenderSVGResource): + (WebCore::RenderSVGResource::isSVGResource): + (WebCore::RenderSVGResource::drawsContents): + (WebCore::getRenderSVGResourceById): + * rendering/RenderSVGResourceMasker.cpp: Added. + (WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker): + (WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker): + (WebCore::RenderSVGResourceMasker::invalidateClients): Status of masker changed, remove all clients. + (WebCore::RenderSVGResourceMasker::invalidateClient): Status of an object changed, remove pending client. + (WebCore::RenderSVGResourceMasker::applyResource): Apply masker to object. + (WebCore::RenderSVGResourceMasker::resourceBoundingBox): boundingBox of the resource, depending on the object. + (WebCore::RenderSVGResourceMasker::createMaskImage): Creates the mask image, the context gets clipped with. + * rendering/RenderSVGResourceMasker.h: Added. + (WebCore::MaskerData::MaskerData): + (WebCore::RenderSVGResourceMasker::renderName): + (WebCore::RenderSVGResourceMasker::maskUnits): Unit of mask for DRT. + (WebCore::RenderSVGResourceMasker::maskContentUnits): Unit of childs from mask for DRT. + (WebCore::RenderSVGResourceMasker::resourceType): + * rendering/RenderSVGRoot.cpp: + (WebCore::RenderSVGRoot::destroy): Renderer gets destroyed, unregister it from it's resources. + * rendering/RenderSVGRoot.h: + * rendering/RenderSVGText.cpp: + (WebCore::RenderSVGText::destroy): dito. + * rendering/RenderSVGText.h: + * rendering/RenderTreeAsText.cpp: + (WebCore::write): + * rendering/SVGRenderSupport.cpp: + (WebCore::SVGRenderBase::prepareToRenderSVGContent): + (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer): + (WebCore::SVGRenderBase::deregisterFromResources): Unregister object from all it's resources after status changed. + * rendering/SVGRenderSupport.h: + (WebCore::SVGRenderBase::toSVGRenderBase): + (WebCore::SVGRenderBase::strokeBoundingBox): + (WebCore::SVGRenderBase::markerBoundingBox): + * rendering/SVGRenderTreeAsText.cpp: Update TreeAsText to dump maskers correctly. + (WebCore::operator<<): + (WebCore::writeSVGResource): + (WebCore::writeSVGContainer): + (WebCore::writeSVGText): + (WebCore::writeSVGInlineText): + (WebCore::writeSVGImage): + (WebCore::write): + (WebCore::writeResourcesToObject): + * rendering/SVGRenderTreeAsText.h: + * svg/SVGMaskElement.cpp: Update Masker to use the new renderer. + (WebCore::SVGMaskElement::svgAttributeChanged): + (WebCore::SVGMaskElement::childrenChanged): + (WebCore::SVGMaskElement::maskBoundingBox): + (WebCore::SVGMaskElement::createRenderer): + * svg/SVGMaskElement.h: + * svg/SVGStyledElement.cpp: We need to tell the renderer to unregister object, after the status changed. + (WebCore::SVGStyledElement::invalidateResources): + (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain): + * svg/SVGUnitTypes.h: Conversion of integer to SVGUnitType. + (WebCore::toUnitType): + * svg/graphics/SVGResource.h: + (WebCore::): + (WebCore::SVGResource::isMarker): + * svg/graphics/SVGResourceMasker.cpp: Removed. + * svg/graphics/SVGResourceMasker.h: Removed. - Check if the familly exist before creating the PlatformData from it. +2010-02-18 Dumitru Daniliuc - https://bugs.webkit.org/show_bug.cgi?id=29443 + Reviewed by Dimitri Glazkov. - Test: svg/text/text-font-invalid.html + Allow creating/dropping virtual tables when the module is FTS2. - * platform/graphics/qt/FontFallbackListQt.cpp: - (WebCore::FontFallbackList::fontDataAt): + https://bugs.webkit.org/show_bug.cgi?id=34867 -2009-11-14 Antonio Gomes + * storage/DatabaseAuthorizer.cpp: + (WebCore::DatabaseAuthorizer::createVTable): + (WebCore::DatabaseAuthorizer::dropVTable): - Reviewed by Antti Koivisto. +2010-02-18 Peter Kasting - [Qt] Broken back/forward after using ErrorPageExtension to set error page - https://bugs.webkit.org/show_bug.cgi?id=30573 + Not reviewed, Chromium build fix. - Make FrameLoader::checkLoadCompleteForThisFrame method - to check for any working DocumentLoader instance (through - activeDocumentLoader()) instead of only checking for - 'm_provisionalDocumentLoader' in order to decide to if - it is going to reset of not the back and forward history. - after an error page has been loaded. + r54963 had a typo in the WebCore.gypi change. + https://bugs.webkit.org/show_bug.cgi?id=35003 - Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html + * WebCore.gypi: - * loader/FrameLoader.cpp: - (WebCore::FrameLoader::checkLoadCompleteForThisFrame): +2010-02-18 Vangelis Kokkevis -2009-11-09 Laszlo Gombos + Reviewed by Simon Fraser. - Reviewed by Kenneth Rohde Christiansen. + Changing forward declaration of TimingFunction in GraphicsLayer.h from + class to struct to match its actual definition in TimingFunction.h - [Qt] Few classes have virtual functions but non-virtual destructor - https://bugs.webkit.org/show_bug.cgi?id=31269 + https://bugs.webkit.org/show_bug.cgi?id=35069 - No new tests as there is no functional change. - * platform/qt/QWebPageClient.h: - (QWebPageClient::~QWebPageClient): Add virtual destructor. + * platform/graphics/GraphicsLayer.h: + Change forward declaration from: class TimingFunction to: + struct TimingFunction -2009-11-09 Yael Aharon +2010-02-18 Noam Rosenthal Reviewed by Kenneth Rohde Christiansen. - [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest - https://bugs.webkit.org/show_bug.cgi?id=31140 + [Qt] Minor improvement to hybrid QPixmap + https://bugs.webkit.org/show_bug.cgi?id=34507 + Instead of having toHTMLImageElement which creates a new element, + assignToHTMLImageElement would set an existing HTML element to + contain the native QPixmap/QImge. + Also made some style fixes. - QtNetwork interprets null string as request to remove the header, not add it. - Replace null values with empty values before passing them to QtNetwork. + Additions to existing tests: see WebKit/qt/tests - Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html + * bridge/qt/qt_pixmapruntime.cpp: + (JSC::Bindings::QtPixmapWidthField::valueFromInstance): style + (JSC::Bindings::QtPixmapHeightField::valueFromInstance): style + (JSC::Bindings::QtPixmapAssignToElementMethod::name): assignTo + (JSC::Bindings::QtPixmapAssignToElementMethod::invoke): new function + (JSC::Bindings::QtPixmapAssignToElementMethod::numParameters): 1 + (JSC::Bindings::QtPixmapToDataUrlMethod::invoke): style + (JSC::Bindings::QtPixmapToStringMethod::invoke): style + (JSC::Bindings::QtPixmapInstance::invokeMethod): style + (JSC::Bindings::QtPixmapClass::methodsNamed): new func, removed old + (JSC::Bindings::QtPixmapInstance::getPropertyNames): ditto + (JSC::Bindings::QtPixmapInstance::defaultValue): style + (JSC::Bindings::QtPixmapInstance::valueOf): style + (JSC::Bindings::QtPixmapInstance::toPixmap): style + (JSC::Bindings::QtPixmapInstance::variantFromObject): style - * platform/network/qt/ResourceRequestQt.cpp: - (WebCore::ResourceRequest::toNetworkRequest): +2010-02-18 Peter Kasting -2009-11-05 Jakub Wieczorek + Not reviewed, bustage fix. - Reviewed by Holger Freyther. + An extraneous line in r54839 broke GIF animation. - [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found. - https://bugs.webkit.org/show_bug.cgi?id=31144 + * platform/image-decoders/gif/GIFImageReader.cpp: + (GIFImageReader::read): - XMLTokenizer::doEnd() uses an additional logic to report a parse failure in - documents that end prematurely but are not considered invalid by QXmlStream. - This is to stay compatible with the libxml2 implementation. - However, that code path would be also hit in situations when it should not, - i.e. the error would have already been caught and handled. As a result, the - same error would be reported twice. +2010-02-18 Dan Bernstein - No new tests, because the problem is already covered by - fast/parser/xml-declaration-missing-ending-mark.html. + Reviewed by Simon Fraser. - * dom/XMLTokenizerQt.cpp: - (WebCore::XMLTokenizer::doEnd): + REGRESSION: Selection painting issue in bug review textbox + https://bugs.webkit.org/show_bug.cgi?id=34946 -2009-11-05 Yuta Kitamura + Test: fast/repaint/selection-gap-overflow-scroll-2.html - Reviewed by Eric Seidel. + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::paintSelection): localToContainerQuad() adjusts for + overflow scroll, but RenderLayer::addBlockSelectionGapsBounds() takes + non-scrolled coordinates, so account for that. - Fix ASSERT(currentStyle = renderStyle()). - https://bugs.webkit.org/show_bug.cgi?id=31152 +2010-02-17 Dumitru Daniliuc - * dom/Element.cpp: - (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=". + Reviewed by Darin Adler. -2009-11-04 Yael Aharon + Change the V8 and JSC SQLStatementErrorCallback to interpret + 'undefined' return values as 'true', as required by the spec. - Reviewed by Tor Arne Vestbø. + https://bugs.webkit.org/show_bug.cgi?id=35048 - [Qt] ASSERT failure when receiving 401 HTTP Authentication response. - https://bugs.webkit.org/show_bug.cgi?id=31077 + * bindings/js/JSCustomSQLStatementErrorCallback.cpp: + (WebCore::JSCustomSQLStatementErrorCallback::handleEvent): + * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: + (WebCore::V8CustomSQLStatementErrorCallback::handleEvent): + * bindings/v8/custom/V8CustomVoidCallback.cpp: + (WebCore::invokeCallbackHelper): + (WebCore::invokeCallback): + (WebCore::invokeCallbackTreatUndefinedAsTrue): + * bindings/v8/custom/V8CustomVoidCallback.h: - Allow sending the response body under the same conditions that we - allow it to finish without reporting an error. +2010-02-17 Ojan Vafai - * platform/network/qt/QNetworkReplyHandler.cpp: - (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): + Reviewed by Adam Barth. -2009-11-03 Evan Martin + keyboard selection sometimes moves the wrong end of the selection for Win/Linux + https://bugs.webkit.org/show_bug.cgi?id=35066 - Reviewed by Darin Adler. + On Windows/Linux keyboard based selections should always move the same + end of the seleciton. On Mac, lineboundary and documentboundary changes + move different ends of the selection depending on which direction your + extending. - Fix an off-by-one in the CSS lexer that causes memory corruption in - hard-to-trigger circumstances. + Test: editing/selection/extend-after-mouse-selection.html - https://bugs.webkit.org/show_bug.cgi?id=30827 + * editing/SelectionController.cpp: + (WebCore::SelectionController::positionForPlatform): + (WebCore::SelectionController::startForPlatform): + (WebCore::SelectionController::endForPlatform): + (WebCore::SelectionController::modifyExtendingRight): + (WebCore::SelectionController::modifyExtendingForward): + (WebCore::SelectionController::modifyMovingForward): + (WebCore::SelectionController::modifyExtendingBackward): + (WebCore::SelectionController::modifyMovingBackward): + * editing/SelectionController.h: - Test: fast/css/end-of-buffer-crash.html +2010-02-18 Timothy Hatcher - * css/maketokenizer: Add comments, fix off-by-one. + Add "with" to the list of keywords to syntax highlight. -2009-11-02 Darin Adler + http://webkit.org/b/35123 - Reviewed by Dan Bernstein. + Reviewed by Pavel Feldman. - Crash due to double-destroy related to CSS run-in property - https://bugs.webkit.org/show_bug.cgi?id=31034 - rdar://problem/7328458 + * inspector/front-end/SourceJavaScriptTokenizer.js: + (WebInspector.SourceJavaScriptTokenizer): Add "width" to _keywords. + * inspector/front-end/SourceJavaScriptTokenizer.re2js: + (WebInspector.SourceJavaScriptTokenizer): Ditto. - Test: fast/css/run-in-crash.html +2010-02-17 Peter Kasting - * rendering/RenderBlock.cpp: - (WebCore::RenderBlock::destroy): Reorder destruction so the - continuation is destroyed after anonymous children. See comment - in the code for more details of why this is right. - * rendering/RenderInline.cpp: - (WebCore::RenderInline::destroy): Ditto. + Reviewed by Adam Barth. -2009-10-30 Kenneth Rohde Christiansen + Rework PNG-in-ICO decoding to copy the decoded framebuffer into the ICO + decoder, making the logic less crazy and more like the other decoders. + https://bugs.webkit.org/show_bug.cgi?id=28751 - Reviewed by Holger Hans Peter Freyther. + * platform/image-decoders/ImageDecoder.cpp: + (WebCore::RGBA32Buffer::operator=): + * platform/image-decoders/ImageDecoder.h: + (WebCore::RGBA32Buffer::RGBA32Buffer): + * platform/image-decoders/ico/ICOImageDecoder.cpp: + (WebCore::ICOImageDecoder::frameBufferAtIndex): + (WebCore::ICOImageDecoder::decodeAtIndex): + * platform/image-decoders/ico/ICOImageDecoder.h: + * platform/image-decoders/qt/RGBA32BufferQt.cpp: + (WebCore::RGBA32Buffer::operator=): + * platform/image-decoders/skia/ImageDecoderSkia.cpp: + (WebCore::RGBA32Buffer::operator=): - If the owner widget of the page has a palette set, we - should use that one. This was only working when the - owner was a QWebView. This patch fixes that. +2010-02-18 Pavel Feldman - * platform/qt/RenderThemeQt.cpp: - (WebCore::RenderThemeQt::applyTheme): - -2009-10-29 Xan Lopez + Reviewed by Timothy Hatcher. - Reviewed by Oliver Hunt. + Web Inspector: multiple popovers on screen at the same time. - [GTK] Threading problems with some of the tests - https://bugs.webkit.org/show_bug.cgi?id=30814 + https://bugs.webkit.org/show_bug.cgi?id=35105 - Create strings shared among threads with crossThreadString - constructor method. + * inspector/front-end/Popover.js: + (WebInspector.Popover.prototype.show): + (WebInspector.Popover.prototype.hide): + * inspector/front-end/SourceFrame.js: + (WebInspector.SourceFrame.prototype._showPopup): - * storage/Database.cpp: - (WebCore::Database::Database): +2010-02-18 Pavel Feldman -2009-10-30 Tor Arne Vestbø + Reviewed by Timothy Hatcher. - Reviewed by NOBODY (OOPS!). + Web Inspector: Expand Object.__proto__ properly. - [Qt] Use the default timeout interval for JS as the HTML tokenizer delay for setHtml() + https://bugs.webkit.org/show_bug.cgi?id=35113 - This ensures that long-running JavaScript (for example due to a modal alert() dialog), - will not trigger a deferred load after only 500ms (the default tokenizer delay) while - still giving a reasonable timeout (10 seconds) to prevent deadlock. + * inspector/front-end/EventListenersSidebarPane.js: + * inspector/front-end/InjectedScript.js: + (injectedScriptConstructor): + * inspector/front-end/ObjectProxy.js: + (WebInspector.ObjectProxy): + * inspector/front-end/PropertiesSidebarPane.js: + (WebInspector.PropertiesSidebarPane.prototype.update.callback): + * inspector/front-end/inspector.js: + (WebInspector.log.logMessage): + (WebInspector.log): - https://bugs.webkit.org/show_bug.cgi?id=29381 +2010-02-18 Nate Chapin - * html/HTMLTokenizer.cpp: Change debug output to print the actual tokenizer delay + Reviewed by Adam Barth. -2009-10-30 Tor Arne Vestbø + [V8] Merge the DOMWindow and WorkerContext object wrapping code paths, + and use a faster method of disambiguating between the types of contexts. - Reviewed by NOBODY (OOPS!). + https://bugs.webkit.org/show_bug.cgi?id=35009 - Clear the initial request when loading synchronously to prevent duplicate loads + * bindings/scripts/CodeGeneratorV8.pm: Remove logic determining whether we need to + handle the WorkerContext case. + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::globalObjectPrototypeIsDOMWindow): + (WebCore::V8DOMWrapper::instantiateV8Object): Merge instantiateV8Object paths. + * bindings/v8/V8DOMWrapper.h: - MainResourceLoader uses the member m_initialRequest to store a request for future - deferred loads. When doing a synchronous load, in handleDataLoadNow(), we therefore - have to clear this request so that subsequent entries into the loader will not start - yet another load. +2010-02-18 Xan Lopez - This can for example happen in setDefersLoading() as a result of a PageGroupLoadDeferrer - going out of scope when returning from Chrome::runJavaScriptAlert(), where the alert() - came from a script executed as part of the first/original load. + Reviewed by Gustavo Noronha. - https://bugs.webkit.org/show_bug.cgi?id=30879 + Remove some duplication between PluginView and Widget methods, and + move the setSelfVisible calls to the parent class. - * loader/MainResourceLoader.cpp: - (WebCore::MainResourceLoader::handleDataLoadNow): clear m_initialRequest + * platform/gtk/WidgetGtk.cpp: + (WebCore::Widget::show): + (WebCore::Widget::hide): + * plugins/gtk/PluginViewGtk.cpp: + (WebCore::PluginView::setFocus): + (WebCore::PluginView::show): + (WebCore::PluginView::hide): -2009-11-04 Jocelyn Turcotte +2010-02-18 Simon Fraser - Reviewed by Timothy Hatcher. + Reviewed by Darin Adler. - WebInspector: Use a different method to identify the webkit port in - InspectorBackent::platform(). - This corrects the inspector expected behavior with Qt on Windows. - https://bugs.webkit.org/show_bug.cgi?id=31116 + Switch Leopard back to using CGShading to avoid CGGradient leaks - * inspector/InspectorBackend.cpp: - (WebCore::InspectorBackend::platform): - (WebCore::InspectorBackend::port): - * inspector/InspectorBackend.h: - * inspector/InspectorBackend.idl: - * inspector/front-end/InspectorControllerStub.js: - (.WebInspector.InspectorControllerStub.prototype.port): - * inspector/front-end/inspector.css: - * inspector/front-end/inspector.js: - (WebInspector.loaded): - (WebInspector.toolbarDragStart): + Define USE_CG_SHADING on for Tiger and Leopard, and use it to toggle the methods + used for Core Graphics gradient drawing. -2009-11-12 Benjamin Poulain + * platform/graphics/Gradient.h: + * platform/graphics/cg/GradientCG.cpp: + (WebCore::Gradient::platformDestroy): + (WebCore::Gradient::paint): - Reviewed by Kenneth Rohde Christiansen. +2010-02-18 Pavel Feldman - Custom printing shrink factors - https://bugs.webkit.org/show_bug.cgi?id=29042 + Reviewed by Timothy Hatcher. - This reverts commit r49769. The public API for this needs to be reviewed - before its inclusion in Qt. + Web Inspector: on-hover evaluation renders nodes and arrays as strings. - * page/PrintContext.cpp: - (WebCore::PrintContext::begin): - * page/Settings.cpp: - (WebCore::Settings::Settings): - * page/Settings.h: + https://bugs.webkit.org/show_bug.cgi?id=35103 -2009-11-09 Norbert Leser + * inspector/front-end/SourceFrame.js: + (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): - Reviewed by Kenneth Rohde Christiansen. +2010-02-18 Brady Eidson - Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2, - since adjustment of RW-section base address will be needed for all new symbian - tool chains, specifically for arm and gcc compilation targets. - Also, change target address to 0xE00000 to be sufficient for all targets. + Reviewed by Sam Weinig. - * WebCore.pro: + Particularly constructed WebFrames can try to access a null HistoryItem + and https://bugs.webkit.org/show_bug.cgi?id=35063 -2009-11-11 Jocelyn Turcotte + Test: fast/loader/api-test-new-window-data-load-base-url.html - Reviewed by Eric Seidel. + * loader/HistoryController.cpp: + (WebCore::HistoryController::updateBackForwardListForFragmentScroll): We have a known case where a fragment scroll + might take place with a null m_currentItem. updateBackForwardListClippedAtTarget() will either move m_currentItem + to m_previousItem then create a new m_currentItem... or it will do nothing. So we either have both an m_currentItem + and m_previousItem, or we have neither. In the case where we have no m_previousItem, return early. - [Qt] Make the default style background color valid. - Currently the color is transparent but invalid, this causes - list boxes in QtWebKit to be drawn with a black background - since r49242. - https://bugs.webkit.org/show_bug.cgi?id=31295 +2010-02-18 Nate Chapin - * rendering/style/RenderStyle.h: - (WebCore::InheritedFlags::initialBackgroundColor): - * rendering/style/StyleBackgroundData.cpp: - (WebCore::StyleBackgroundData::StyleBackgroundData): + Reviewed by Eric Seidel. -2009-11-11 Simon Hausmann + [V8] Correctly handle the case where the event field on the + global object is a v8::Object, but not a DOM wrapper. - Reviewed by Tor Arne Vestbø. + https://bugs.webkit.org/show_bug.cgi?id=34899 - Introduce a function for querying the input method status - in QWebPageClient. + Test: fast/dom/Window/window-event-override-no-crash.html - * platform/qt/QWebPageClient.h: + * bindings/v8/ScriptController.cpp: + (WebCore::ScriptController::processingUserGesture): + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::V8DOMWrapper::isValidDOMObject): + (WebCore::V8DOMWrapper::isWrapperOfType): + * bindings/v8/V8DOMWrapper.h: -2009-11-09 Yael Aharon +2010-02-18 Pavel Feldman - Reviewed by Kenneth Rohde Christiansen. + Not reviewed, Qt build fix. - [Qt] Pass credentials provided by XMLHTTPRequest to the network request. - https://bugs.webkit.org/show_bug.cgi?id=31208 + * inspector/front-end/WebKit.qrc: - After r42483, the credentials are no longer passed to the network request - in the URL of the request. - Pass the credentials from XMLHTTPRequest to the network request, the same - way that other ports do. +2010-02-18 Pavel Feldman - After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes. + Reviewed by Timothy Hatcher. - * platform/network/qt/ResourceHandleQt.cpp: - (WebCore::ResourceHandle::start): - (WebCore::ResourceHandle::loadResourceSynchronously): + Web Inspector: Implement evaluate-on-hover for scripts panel. -2009-11-03 Simon Hausmann + https://bugs.webkit.org/show_bug.cgi?id=35003 + + * WebCore.gypi: + * WebCore.vcproj/WebCore.vcproj: + * inspector/front-end/Images/gearButtonGlyph.png: Added. + * inspector/front-end/Images/popoverArrows.png: Added. + * inspector/front-end/Images/popoverBackground.png: Added. + * inspector/front-end/Images/thumbActiveHoriz.png: Added. + * inspector/front-end/Images/thumbActiveVert.png: Added. + * inspector/front-end/Images/thumbHoriz.png: Added. + * inspector/front-end/Images/thumbHoverHoriz.png: Added. + * inspector/front-end/Images/thumbHoverVert.png: Added. + * inspector/front-end/Images/thumbVert.png: Added. + * inspector/front-end/Images/trackHoriz.png: Added. + * inspector/front-end/Images/trackVert.png: Added. + * inspector/front-end/Popup.js: + (WebInspector.Popup): + (WebInspector.Popup.prototype.show): + (WebInspector.Popup.prototype.hide): + (WebInspector.Popup.prototype._positionElement): + * inspector/front-end/SourceFrame.js: + (WebInspector.SourceFrame.prototype._createViewerIfNeeded): + (WebInspector.SourceFrame.prototype._scroll): + (WebInspector.SourceFrame.prototype._mouseDown): + (WebInspector.SourceFrame.prototype._mouseUp): + (WebInspector.SourceFrame.prototype._mouseMove): + (WebInspector.SourceFrame.prototype._mouseOut): + (WebInspector.SourceFrame.prototype._resetHoverTimer): + (WebInspector.SourceFrame.prototype._hidePopup): + (WebInspector.SourceFrame.prototype._mouseHover): + (WebInspector.SourceFrame.prototype._showPopup.showTextPopup): + (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): + (WebInspector.SourceFrame.prototype._showPopup.evaluateCallback): + (WebInspector.SourceFrame.prototype._showPopup): + (WebInspector.HoverPropertiesSection): + (WebInspector.HoverPropertiesSection.prototype.update): + * inspector/front-end/TextEditorHighlighter.js: + (WebInspector.TextEditorHighlighter): + (WebInspector.TextEditorHighlighter.prototype._lex): + * inspector/front-end/TextViewer.js: + (WebInspector.TextViewer.prototype._paintLine): + * inspector/front-end/WebKit.qrc: + * inspector/front-end/inspector.css: + * inspector/front-end/inspector.html: + * inspector/front-end/inspectorSyntaxHighlight.css: + * inspector/front-end/popover.css: Added. - Unreviewed build fix for WebInspector with Qt build. +2010-02-18 Ben Murdoch - Simply re-generate the Qt resource file by running - WebKitTools/Scripts/generate-qt-inspector-resource + Reviewed by Jeremy Orlow. - * inspector/front-end/WebKit.qrc: + [v8] Complete upstreaming of V8 Touch Event bindings + https://bugs.webkit.org/show_bug.cgi?id=35094 -2009-11-03 Simon Hausmann + No new tests required. - Reviewed by Tor Arne Vestbø. + * bindings/v8/V8Index.cpp: Add generated touch event headers. - Make QWebPluginDatabase private API for now. +2010-02-18 Steve Block - https://bugs.webkit.org/show_bug.cgi?id=30775 + Reviewed by Jeremy Orlow. - * WebCore.pro: + Updates Android V8 build to use DerivedSourcesAllInOne.cpp + https://bugs.webkit.org/show_bug.cgi?id=35083 -2009-11-03 Simon Hausmann + No new tests, build fix only. - Reviewed by Tor Arne Vestbø. + * Android.derived.v8bindings.mk: + * Android.v8bindings.mk: - Extended the conversion of the WebCore ResourceRequest to the - QNetworkRequest with a mandatory originating object argument, - which is meant to be the QWebFrame the request belongs to. +2010-02-18 Gustavo Noronha Silva - https://bugs.webkit.org/show_bug.cgi?id=29975 + Reviewed by Xan Lopez. - * platform/network/qt/QNetworkReplyHandler.cpp: - (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): - (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): - (WebCore::QNetworkReplyHandler::start): - * platform/network/qt/ResourceRequest.h: - * platform/network/qt/ResourceRequestQt.cpp: - (WebCore::ResourceRequest::toNetworkRequest): + fast/frames/iframe-reparenting.html crashing on GTK Debug bots + https://bugs.webkit.org/show_bug.cgi?id=35081 -2009-11-02 Jedrzej Nowacki + Check that the client is alive after every call to it, since any + of them could cause the load to be cancelled, and the client to go + away. - Reviewed by Adam Barth. + This is much better than protecting a specific subclass of + ResourceHandleClient (ResourceLoader), which makes us fail when + any other client is used. - QWebView crash fix. + Test: fast/frames/iframe-reparenting.html - The QWebView should not crash if the stop() method is called from - a function triggered by the loadProgress signal. + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::parseDataUrl): - A null pointer protection was added in the ProgressTracker::incrementProgress. +2010-02-18 Ben Murdoch - New autotest was created. + Reviewed by Nate Chapin. - https://bugs.webkit.org/show_bug.cgi?id=29425 + [v8] [Android] V8 bindings for touch events are missing. + https://bugs.webkit.org/show_bug.cgi?id=33795 - * loader/ProgressTracker.cpp: - (WebCore::ProgressTracker::incrementProgress): + No new tests as this just enables touch events in V8. Existing touch tests suffice. -2009-11-02 Kai Koehne + * WebCore.gypi: Add Touch idl files. + * bindings/scripts/CodeGeneratorV8.pm: Add TouchList to typeCanFailConversion map. + * bindings/v8/DOMObjectsInclude.h: Add touch headers. + * bindings/v8/DerivedSourcesAllInOne.cpp: Add touch generated bindings. + * bindings/v8/V8Index.h: Add touch DOM object types. + * bindings/v8/custom/V8EventCustom.cpp: Add conversion of event to touch event. + * Android.derived.jscbindings.mk: Add the touch derived sources to the makefile. + * Android.derived.v8bindings.mk: Add the touch derived sources to the makefile. - Reviewed by Holger Freyther. +2010-02-18 William Chan - Remove implementation of ImageDecocerQt::clearFrameBufferCache. - The implementation was buggy, and will visually break repeating - animations anyway. + Reviewed by Adam Barth. - https://bugs.webkit.org/show_bug.cgi?id=31009 + https://bugs.webkit.org/show_bug.cgi?id=35071 + Disable loader limiting of requests per host for the chromium port. - * platform/graphics/qt/ImageDecoderQt.cpp: - (WebCore::ImageDecoderQt::clearFrameBufferCache): + No tests because we're only changing a constant. -2009-11-01 Yael Aharon + * platform/network/chromium/ResourceRequest.cpp: + (WebCore::initializeMaximumHTTPConnectionCountPerHost): - Reviewed by Darin Adler. +2010-02-18 Xan Lopez - Don't add '/' to the URL path if the it does not include '/' after the protocol component - https://bugs.webkit.org/show_bug.cgi?id=30971 + Reviewed by Eric Seidel. - Match IE8 behaviour, that does not add '/' if there is none after the protocol component. + [Linux] Webkit incompatible with Java plugins + https://bugs.webkit.org/show_bug.cgi?id=24912 - * platform/KURL.cpp: - (WebCore::KURL::parse): + The NP Version supported by WebKit is at the moment hardcoded in + PluginPackage.cpp (to 24), but not all backends actually implement + the methods needed to claim this. Introduce a new method to be + implemented by each backend where the maximum supported version + can be specified, and set the GTK+ port NPVersion to 19. This + fixes an instantaneous crasher in the Sun Java NPAPI plugin. -2009-10-30 Kenneth Rohde Christiansen + * plugins/PluginPackage.cpp: + (WebCore::PluginPackage::initializeBrowserFuncs): + * plugins/PluginPackage.h: + * plugins/gtk/PluginPackageGtk.cpp: + (WebCore::PluginPackage::NPVersion): + * plugins/mac/PluginPackageMac.cpp: + (WebCore::PluginPackage::NPVersion): + * plugins/qt/PluginPackageQt.cpp: + (WebCore::PluginPackage::NPVersion): + * plugins/symbian/PluginPackageSymbian.cpp: + (WebCore::PluginPackage::NPVersion): + * plugins/win/PluginPackageWin.cpp: + (WebCore::PluginPackage::NPVersion): - Reviewed by Holger Hans Peter Freyther. +2010-02-17 Dmitry Titov - If the owner widget of the page has a palette set, we - should use that one. This was only working when the - owner was a QWebView. This patch fixes that. + Reviewed by David Levin, Darin Fisher, Simon Hausmann. - * platform/qt/RenderThemeQt.cpp: - (WebCore::RenderThemeQt::applyTheme): + When a live iframe element is moved between pages, it still depends on the old page. + https://bugs.webkit.org/show_bug.cgi?id=34382 -2009-10-29 Laszlo Gombos + Test: fast/frames/iframe-reparenting-new-page.html - Reviewed by Tor Arne Vestbø. + * html/HTMLFrameElementBase.cpp: + (WebCore::HTMLFrameElementBase::setName): + Move the code setting the frame name into a separate function. - [Qt] Implement DELETE HTTP method for XmlHttpRequest - https://bugs.webkit.org/show_bug.cgi?id=30894 + (WebCore::HTMLFrameElementBase::setNameAndOpenURL): + (WebCore::HTMLFrameElementBase::updateOnReparenting): + Called on the frame that was just re-parented and inserted into another Document. + Simply invoke Frame::transferChildFrameToNewDocument(...); - No new tests as this functionality is already tested by the - xmlhttprequest LayoutTests. As this patch depends on an unreleased - version of the dependent QtNetwork library and the tests will be - enabled later once the dependent library is released (and the - buildbot is updated). + (WebCore::HTMLFrameElementBase::insertedIntoDocument): + * html/HTMLFrameElementBase.h: + * html/HTMLFrameOwnerElement.h: + (WebCore::HTMLFrameOwnerElement::setName): + Make this a virtual function, to be able to reach it via Frame::m_ownerElement. - * platform/network/qt/QNetworkReplyHandler.cpp: - (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): - (WebCore::QNetworkReplyHandler::start): + * loader/EmptyClients.h: + (WebCore::EmptyFrameLoaderClient::adoptFrame): + * loader/FrameLoaderClient.h: + Add a new method, didTransferChildFrameToNewDocument(). + It compliments createFrame() in that a frame which was re-parented + in DOM and potentially changes Page, should notify the WebKit + implementation about potential ownership change. + Many embedders assume that Page owns all the Frames, or at least + all Frames are destroyed before 'their' Page is destroyed. Obviously, if Frame + can be transferred to another Page, the embedders should be notified. -2009-11-02 Tor Arne Vestbø + * page/Frame.cpp: + (WebCore::Frame::transferChildFrameToNewDocument): + Added, makes actual adjustments for Frame - resets the Page, + updates the frame tree and frame name, calls to FrameLoaderClient + to update external objects and recurses into children. + Can only be used on child frames. - Rubber-stamped by Antti Koivisto. + * page/Frame.h: - [Qt] Build fix for Windows CE +2010-02-17 Tony Chang - * plugins/PluginDatabase.cpp: + Reviewed by Eric Seidel. -2009-11-02 Jocelyn Turcotte + Copying and pasting into a contenteditable area can create