summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPiotr Paczkowski (trzeci.eu) <kontakt@trzeci.eu>2019-12-20 08:39:06 (GMT)
committerGitHub <noreply@github.com>2019-12-20 08:39:06 (GMT)
commit77b3a250ea9e7c6d01b6eba1dfe70568b7e1fabc (patch)
treef46268f655f5b655e924804d9633715471e3bb04
parent9d8222ad667284cfad8be9cb27b25dab75f34ccb (diff)
downloadgoogletest-77b3a250ea9e7c6d01b6eba1dfe70568b7e1fabc.zip
googletest-77b3a250ea9e7c6d01b6eba1dfe70568b7e1fabc.tar.gz
googletest-77b3a250ea9e7c6d01b6eba1dfe70568b7e1fabc.tar.bz2
Review notes: Return T& from assignment operators
-rw-r--r--googletest/include/gtest/internal/gtest-port.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/googletest/include/gtest/internal/gtest-port.h b/googletest/include/gtest/internal/gtest-port.h
index 95a9479..1a7f80c 100644
--- a/googletest/include/gtest/internal/gtest-port.h
+++ b/googletest/include/gtest/internal/gtest-port.h
@@ -671,7 +671,7 @@ typedef struct _RTL_CRITICAL_SECTION GTEST_CRITICAL_SECTION;
// A macro to disallow copy operator=
// This should be used in the private: declarations for a class.
#define GTEST_DISALLOW_ASSIGN_(type) \
- void operator=(type const &) = delete
+ type& operator=(type const &) = delete
// A macro to disallow copy constructor and operator=
// This should be used in the private: declarations for a class.
@@ -682,7 +682,7 @@ typedef struct _RTL_CRITICAL_SECTION GTEST_CRITICAL_SECTION;
// A macro to disallow move operator=
// This should be used in the private: declarations for a class.
#define GTEST_DISALLOW_MOVE_ASSIGN_(type) \
- void operator=(type &&) = delete
+ type& operator=(type &&) = delete
// A macro to disallow move constructor and operator=
// This should be used in the private: declarations for a class.