diff options
| author | Gennadiy Civil <misterg@google.com> | 2018-08-14 20:05:55 (GMT) |
|---|---|---|
| committer | Gennadiy Civil <misterg@google.com> | 2018-08-14 20:05:55 (GMT) |
| commit | f0e4c411ca08f01068162483e92810001b178a60 (patch) | |
| tree | 8ff09c590425eb6c930cad693d39641efcc7a1b0 | |
| parent | bbf738a2c1052d9822fc69d4dd660190752e63b8 (diff) | |
| download | googletest-f0e4c411ca08f01068162483e92810001b178a60.zip googletest-f0e4c411ca08f01068162483e92810001b178a60.tar.gz googletest-f0e4c411ca08f01068162483e92810001b178a60.tar.bz2 | |
more comments changesrefs/pull/1741/head
| -rw-r--r-- | googlemock/src/gmock-spec-builders.cc | 2 | ||||
| -rw-r--r-- | googletest/test/googletest-options-test.cc | 3 | ||||
| -rw-r--r-- | googletest/test/gtest_repeat_test.cc | 3 |
3 files changed, 3 insertions, 5 deletions
diff --git a/googlemock/src/gmock-spec-builders.cc b/googlemock/src/gmock-spec-builders.cc index dc6f5ac..b93f4e0 100644 --- a/googlemock/src/gmock-spec-builders.cc +++ b/googlemock/src/gmock-spec-builders.cc @@ -782,7 +782,7 @@ void Mock::RegisterUseByOnCallOrExpectCall(const void* mock_obj, const TestInfo* const test_info = UnitTest::GetInstance()->current_test_info(); if (test_info != NULL) { - // TODO(wan@google.com): record the test case name when the + // FIXME: record the test case name when the // ON_CALL or EXPECT_CALL is invoked from SetUpTestCase() or // TearDownTestCase(). state.first_used_test_case = test_info->test_case_name(); diff --git a/googletest/test/googletest-options-test.cc b/googletest/test/googletest-options-test.cc index 2a8dcda..edd4eba 100644 --- a/googletest/test/googletest-options-test.cc +++ b/googletest/test/googletest-options-test.cc @@ -105,8 +105,7 @@ TEST(OutputFileHelpersTest, GetCurrentExecutableName) { #elif GTEST_OS_FUCHSIA const bool success = exe_str == "app"; #else - // FIXME: remove the hard-coded "lt-" prefix when - // libtool replacement is ready. + // FIXME: remove the hard-coded "lt-" prefix when libtool replacement is ready const bool success = exe_str == "googletest-options-test" || exe_str == "gtest_all_test" || diff --git a/googletest/test/gtest_repeat_test.cc b/googletest/test/gtest_repeat_test.cc index 50876c7..1e8f499 100644 --- a/googletest/test/gtest_repeat_test.cc +++ b/googletest/test/gtest_repeat_test.cc @@ -117,8 +117,7 @@ const int kNumberOfParamTests = 10; class MyParamTest : public testing::TestWithParam<int> {}; TEST_P(MyParamTest, ShouldPass) { - // FIXME: Make parameter value checking robust - // WRT order of tests. + // FIXME: Make parameter value checking robust WRT order of tests. GTEST_CHECK_INT_EQ_(g_param_test_count % kNumberOfParamTests, GetParam()); g_param_test_count++; } |