diff options
author | misterg <misterg@google.com> | 2018-08-22 20:30:23 (GMT) |
---|---|---|
committer | Gennadiy Civil <misterg@google.com> | 2018-08-23 20:03:46 (GMT) |
commit | 87494afca70c50e62d1915830169558d25ce67a5 (patch) | |
tree | 83974344e47119f9363ec654f67c1b839b510b80 | |
parent | 9dae300121bebe41d93d44926a8de513f6d2d240 (diff) | |
download | googletest-87494afca70c50e62d1915830169558d25ce67a5.zip googletest-87494afca70c50e62d1915830169558d25ce67a5.tar.gz googletest-87494afca70c50e62d1915830169558d25ce67a5.tar.bz2 |
Googletest exportrefs/pull/1779/head
Remove unneeded check for NULL.
Note: this started as OSS PR https://github.com/google/googletest/pull/967 but changed
PiperOrigin-RevId: 209819732
-rw-r--r-- | googletest/src/gtest.cc | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/googletest/src/gtest.cc b/googletest/src/gtest.cc index 888ffd1..e9127a1 100644 --- a/googletest/src/gtest.cc +++ b/googletest/src/gtest.cc @@ -2679,18 +2679,18 @@ void TestInfo::Run() { factory_, &internal::TestFactoryBase::CreateTest, "the test fixture's constructor"); - // Runs the test only if the test object was created and its - // constructor didn't generate a fatal failure. - if ((test != NULL) && !Test::HasFatalFailure()) { + // Runs the test if the constructor didn't generate a fatal failure. + // Note that the object will not be null + if (!Test::HasFatalFailure()) { // This doesn't throw as all user code that can throw are wrapped into // exception handling code. test->Run(); } - // Deletes the test object. - impl->os_stack_trace_getter()->UponLeavingGTest(); - internal::HandleExceptionsInMethodIfSupported( - test, &Test::DeleteSelf_, "the test fixture's destructor"); + // Deletes the test object. + impl->os_stack_trace_getter()->UponLeavingGTest(); + internal::HandleExceptionsInMethodIfSupported( + test, &Test::DeleteSelf_, "the test fixture's destructor"); result_.set_elapsed_time(internal::GetTimeInMillis() - start); |