diff options
author | kosak <kosak@google.com> | 2014-06-18 00:22:42 (GMT) |
---|---|---|
committer | kosak <kosak@google.com> | 2014-06-18 00:22:42 (GMT) |
commit | 96ddffe8fdabccb10fb693a54dcb88bd5b71bc09 (patch) | |
tree | ce5d8e5647e5c70cd0b052ad548ae94ae20431bb | |
parent | 21ee8a2e72871ca50148657bc217e9b838dcd903 (diff) | |
download | googletest-96ddffe8fdabccb10fb693a54dcb88bd5b71bc09.zip googletest-96ddffe8fdabccb10fb693a54dcb88bd5b71bc09.tar.gz googletest-96ddffe8fdabccb10fb693a54dcb88bd5b71bc09.tar.bz2 |
Reduce the number of occurrences of gendered pronouns in gtest.
-rw-r--r-- | include/gtest/gtest.h | 22 | ||||
-rw-r--r-- | src/gtest-death-test.cc | 6 | ||||
-rw-r--r-- | src/gtest-internal-inl.h | 2 | ||||
-rw-r--r-- | src/gtest-port.cc | 6 | ||||
-rw-r--r-- | src/gtest-test-part.cc | 6 | ||||
-rw-r--r-- | src/gtest.cc | 8 |
6 files changed, 25 insertions, 25 deletions
diff --git a/include/gtest/gtest.h b/include/gtest/gtest.h index a19b3db..38ca3e9 100644 --- a/include/gtest/gtest.h +++ b/include/gtest/gtest.h @@ -70,14 +70,14 @@ // class ::string, which has the same interface as ::std::string, but // has a different implementation. // -// The user can define GTEST_HAS_GLOBAL_STRING to 1 to indicate that +// You can define GTEST_HAS_GLOBAL_STRING to 1 to indicate that // ::string is available AND is a distinct type to ::std::string, or // define it to 0 to indicate otherwise. // -// If the user's ::std::string and ::string are the same class due to -// aliasing, he should define GTEST_HAS_GLOBAL_STRING to 0. +// If ::std::string and ::string are the same class on your platform +// due to aliasing, you should define GTEST_HAS_GLOBAL_STRING to 0. // -// If the user doesn't define GTEST_HAS_GLOBAL_STRING, it is defined +// If you do not define GTEST_HAS_GLOBAL_STRING, it is defined // heuristically. namespace testing { @@ -455,17 +455,17 @@ class GTEST_API_ Test { // Uses a GTestFlagSaver to save and restore all Google Test flags. const internal::GTestFlagSaver* const gtest_flag_saver_; - // Often a user mis-spells SetUp() as Setup() and spends a long time + // Often a user misspells SetUp() as Setup() and spends a long time // wondering why it is never called by Google Test. The declaration of // the following method is solely for catching such an error at // compile time: // // - The return type is deliberately chosen to be not void, so it - // will be a conflict if a user declares void Setup() in his test - // fixture. + // will be a conflict if void Setup() is declared in the user's + // test fixture. // // - This method is private, so it will be another compiler error - // if a user calls it from his test fixture. + // if the method is called from the user's test fixture. // // DO NOT OVERRIDE THIS FUNCTION. // @@ -948,7 +948,7 @@ class GTEST_API_ TestCase { }; // An Environment object is capable of setting up and tearing down an -// environment. The user should subclass this to define his own +// environment. You should subclass this to define your own // environment(s). // // An Environment object does the set-up and tear-down in virtual @@ -2231,8 +2231,8 @@ bool StaticAssertTypeEq() { // The convention is to end the test case name with "Test". For // example, a test case for the Foo class can be named FooTest. // -// The user should put his test code between braces after using this -// macro. Example: +// Test code should appear between braces after an invocation of +// this macro. Example: // // TEST(FooTest, InitializesCorrectly) { // Foo foo; diff --git a/src/gtest-death-test.cc b/src/gtest-death-test.cc index 69fe7c1..a0a8c7b 100644 --- a/src/gtest-death-test.cc +++ b/src/gtest-death-test.cc @@ -68,9 +68,9 @@ // Indicates that this translation unit is part of Google Test's // implementation. It must come before gtest-internal-inl.h is -// included, or there will be a compiler error. This trick is to -// prevent a user from accidentally including gtest-internal-inl.h in -// his code. +// included, or there will be a compiler error. This trick exists to +// prevent the accidental inclusion of gtest-internal-inl.h in the +// user's code. #define GTEST_IMPLEMENTATION_ 1 #include "src/gtest-internal-inl.h" #undef GTEST_IMPLEMENTATION_ diff --git a/src/gtest-internal-inl.h b/src/gtest-internal-inl.h index 41fadb1..0ac7a10 100644 --- a/src/gtest-internal-inl.h +++ b/src/gtest-internal-inl.h @@ -40,7 +40,7 @@ // GTEST_IMPLEMENTATION_ is defined to 1 iff the current translation unit is // part of Google Test's implementation; otherwise it's undefined. #if !GTEST_IMPLEMENTATION_ -// A user is trying to include this from his code - just say no. +// If this file is included from the user's code, just say no. # error "gtest-internal-inl.h is part of Google Test's internal implementation." # error "It must not be included except by Google Test itself." #endif // GTEST_IMPLEMENTATION_ diff --git a/src/gtest-port.cc b/src/gtest-port.cc index 39e70bb..b032745 100644 --- a/src/gtest-port.cc +++ b/src/gtest-port.cc @@ -64,9 +64,9 @@ // Indicates that this translation unit is part of Google Test's // implementation. It must come before gtest-internal-inl.h is -// included, or there will be a compiler error. This trick is to -// prevent a user from accidentally including gtest-internal-inl.h in -// his code. +// included, or there will be a compiler error. This trick exists to +// prevent the accidental inclusion of gtest-internal-inl.h in the +// user's code. #define GTEST_IMPLEMENTATION_ 1 #include "src/gtest-internal-inl.h" #undef GTEST_IMPLEMENTATION_ diff --git a/src/gtest-test-part.cc b/src/gtest-test-part.cc index c60eef3..fb0e354 100644 --- a/src/gtest-test-part.cc +++ b/src/gtest-test-part.cc @@ -35,9 +35,9 @@ // Indicates that this translation unit is part of Google Test's // implementation. It must come before gtest-internal-inl.h is -// included, or there will be a compiler error. This trick is to -// prevent a user from accidentally including gtest-internal-inl.h in -// his code. +// included, or there will be a compiler error. This trick exists to +// prevent the accidental inclusion of gtest-internal-inl.h in the +// user's code. #define GTEST_IMPLEMENTATION_ 1 #include "src/gtest-internal-inl.h" #undef GTEST_IMPLEMENTATION_ diff --git a/src/gtest.cc b/src/gtest.cc index 408e6f2..ca3596e 100644 --- a/src/gtest.cc +++ b/src/gtest.cc @@ -1962,8 +1962,8 @@ bool Test::HasSameFixtureClass() { const bool this_is_TEST = this_fixture_id == internal::GetTestTypeId(); if (first_is_TEST || this_is_TEST) { - // The user mixed TEST and TEST_F in this test case - we'll tell - // him/her how to fix it. + // Both TEST and TEST_F appear in same test case, which is incorrect. + // Tell the user how to fix this. // Gets the name of the TEST and the name of the TEST_F. Note // that first_is_TEST and this_is_TEST cannot both be true, as @@ -1983,8 +1983,8 @@ bool Test::HasSameFixtureClass() { << "want to change the TEST to TEST_F or move it to another test\n" << "case."; } else { - // The user defined two fixture classes with the same name in - // two namespaces - we'll tell him/her how to fix it. + // Two fixture classes with the same name appear in two different + // namespaces, which is not allowed. Tell the user how to fix this. ADD_FAILURE() << "All tests in the same test case must use the same test fixture\n" << "class. However, in test case " |