diff options
author | David Benjamin <davidben@google.com> | 2017-02-11 00:19:54 (GMT) |
---|---|---|
committer | David Benjamin <davidben@google.com> | 2018-01-03 19:50:22 (GMT) |
commit | b3d9be5c1d969dfdbf1f1ff924b9fd1be5eaecc9 (patch) | |
tree | 3ffa0c2921d9f401e92ada32cc5f6d1f9f3258b9 /googlemock | |
parent | ba6ecedede74521490f36b6aea08f91fdad6d201 (diff) | |
download | googletest-b3d9be5c1d969dfdbf1f1ff924b9fd1be5eaecc9.zip googletest-b3d9be5c1d969dfdbf1f1ff924b9fd1be5eaecc9.tar.gz googletest-b3d9be5c1d969dfdbf1f1ff924b9fd1be5eaecc9.tar.bz2 |
Pass the -Wmissing-declarations warning.
This makes it easier to use GTest in projects that build with the
-Wmissing-declarations warning. This fixes the warning in headers and
source files, though not GTest's own tests as it is rather noisy there.
Diffstat (limited to 'googlemock')
-rw-r--r-- | googlemock/include/gmock/gmock-matchers.h | 4 | ||||
-rw-r--r-- | googlemock/src/gmock-spec-builders.cc | 2 | ||||
-rw-r--r-- | googlemock/test/gmock-matchers_test.cc | 4 |
3 files changed, 5 insertions, 5 deletions
diff --git a/googlemock/include/gmock/gmock-matchers.h b/googlemock/include/gmock/gmock-matchers.h index c446bf7..3367a0b 100644 --- a/googlemock/include/gmock/gmock-matchers.h +++ b/googlemock/include/gmock/gmock-matchers.h @@ -3615,6 +3615,10 @@ BoundSecondMatcher<Tuple2Matcher, Second> MatcherBindSecond( return BoundSecondMatcher<Tuple2Matcher, Second>(tm, second); } +// Joins a vector of strings as if they are fields of a tuple; returns +// the joined string. This function is exported for testing. +GTEST_API_ string JoinAsTuple(const Strings& fields); + // Returns the description for a matcher defined using the MATCHER*() // macro where the user-supplied description string is "", if // 'negation' is false; otherwise returns the description of the diff --git a/googlemock/src/gmock-spec-builders.cc b/googlemock/src/gmock-spec-builders.cc index fc4968b..93a83ae 100644 --- a/googlemock/src/gmock-spec-builders.cc +++ b/googlemock/src/gmock-spec-builders.cc @@ -508,7 +508,7 @@ bool UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked() return expectations_met; } -CallReaction intToCallReaction(int mock_behavior) { +static CallReaction intToCallReaction(int mock_behavior) { if (mock_behavior >= kAllow && mock_behavior <= kFail) { return static_cast<internal::CallReaction>(mock_behavior); } diff --git a/googlemock/test/gmock-matchers_test.cc b/googlemock/test/gmock-matchers_test.cc index 4beaec4..5c764eb 100644 --- a/googlemock/test/gmock-matchers_test.cc +++ b/googlemock/test/gmock-matchers_test.cc @@ -65,10 +65,6 @@ namespace testing { -namespace internal { -GTEST_API_ string JoinAsTuple(const Strings& fields); -} // namespace internal - namespace gmock_matchers_test { using std::greater; |